Change in ...coreboot[master]: sb/intel/common: Make linking pmbase.c conditional

[Arthur Heymans (Code Review)]

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33200

Change subject: sb/intel/common: Make linking pmbase.c conditional
......................................................................

sb/intel/common: Make linking pmbase.c conditional

Change-Id: I6a7cd96699dbeb42a53bf1d25db1bcf93e416e0f
Signed-off-by: Arthur Heymans 
---
M src/southbridge/intel/common/Kconfig
M src/southbridge/intel/common/Makefile.inc
2 files changed, 8 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/33200/1

diff --git a/src/southbridge/intel/common/Kconfig b/src/southbridge/intel/common/Kconfig
index c3bd90d..42717b0 100644
--- a/src/southbridge/intel/common/Kconfig
+++ b/src/southbridge/intel/common/Kconfig
@@ -10,6 +10,10 @@
    def_bool n
    depends on SOUTHBRIDGE_INTEL_COMMON

+config SOUTHBRIDGE_INTEL_COMMON_PMBASE
+	def_bool n
+	depends on SOUTHBRIDGE_INTEL_COMMON
+
 config SOUTHBRIDGE_INTEL_COMMON_GPIO
    def_bool n

@@ -35,6 +39,7 @@
    def_bool n
    select HAVE_POWER_STATE_AFTER_FAILURE
    select HAVE_POWER_STATE_PREVIOUS_AFTER_FAILURE
+	select SOUTHBRIDGE_INTEL_PMBASE

config SOUTHBRIDGE_INTEL_COMMON_ACPI_MADT
    bool
diff --git a/src/southbridge/intel/common/Makefile.inc b/src/southbridge/intel/common/Makefile.inc
index dbc9c93..ac2fd8e 100644
--- a/src/southbridge/intel/common/Makefile.inc
+++ b/src/southbridge/intel/common/Makefile.inc
@@ -38,8 +38,10 @@

ifeq ($(CONFIG_SOUTHBRIDGE_INTEL_COMMON),y)

-$(eval $(call add_to_all_stages,y,pmbase.c))
+$(eval $(call add_to_all_stages,$(CONFIG_SOUTHBRIDGE_INTEL_COMMON_PMBASE),pmbase.c))
+ifeq ($(CONFIG_SOUTHBRIDGE_INTEL_COMMON_PMBASE),y)
 smm-y += pmbase.c
+endif

bootblock-$(CONFIG_USBDEBUG) += usb_debug.c
 romstage-$(CONFIG_USBDEBUG) += usb_debug.c

[Arthur Heymans (Code Review)]

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33200

to look at the new patch set (#2).

Change subject: sb/intel/common: Make linking pmbase.c conditional
......................................................................

sb/intel/common: Make linking pmbase.c conditional

Change-Id: I6a7cd96699dbeb42a53bf1d25db1bcf93e416e0f
Signed-off-by: Arthur Heymans 
---
M src/southbridge/intel/common/Kconfig
M src/southbridge/intel/common/Makefile.inc
2 files changed, 8 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/33200/2

[Arthur Heymans (Code Review)]

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33200

to look at the new patch set (#3).

Change subject: sb/intel/common: Make linking pmbase.c conditional
......................................................................

sb/intel/common: Make linking pmbase.c conditional

Change-Id: I6a7cd96699dbeb42a53bf1d25db1bcf93e416e0f
Signed-off-by: Arthur Heymans 
---
M src/southbridge/intel/bd82x6x/Kconfig
M src/southbridge/intel/common/Kconfig
M src/southbridge/intel/common/Makefile.inc
M src/southbridge/intel/i82801gx/Kconfig
M src/southbridge/intel/i82801ix/Kconfig
M src/southbridge/intel/i82801jx/Kconfig
M src/southbridge/intel/ibexpeak/Kconfig
M src/southbridge/intel/lynxpoint/Kconfig
8 files changed, 15 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/33200/3

[Arthur Heymans (Code Review)]

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33200

to look at the new patch set (#4).

Change subject: sb/intel/common: Make linking pmbase.c conditional
......................................................................

sb/intel/common: Make linking pmbase.c conditional

Change-Id: I6a7cd96699dbeb42a53bf1d25db1bcf93e416e0f
Signed-off-by: Arthur Heymans 
---
M src/southbridge/intel/bd82x6x/Kconfig
M src/southbridge/intel/common/Kconfig
M src/southbridge/intel/common/Makefile.inc
M src/southbridge/intel/fsp_rangeley/Kconfig
M src/southbridge/intel/i82801gx/Kconfig
M src/southbridge/intel/i82801ix/Kconfig
M src/southbridge/intel/i82801jx/Kconfig
M src/southbridge/intel/ibexpeak/Kconfig
M src/southbridge/intel/lynxpoint/Kconfig
9 files changed, 17 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/33200/4

[Arthur Heymans (Code Review)]

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33200

to look at the new patch set (#5).

Change subject: sb/intel/common: Make linking pmbase.c conditional
......................................................................

sb/intel/common: Make linking pmbase.c conditional

Change-Id: I6a7cd96699dbeb42a53bf1d25db1bcf93e416e0f
Signed-off-by: Arthur Heymans 
---
M src/southbridge/intel/bd82x6x/Kconfig
M src/southbridge/intel/common/Kconfig
M src/southbridge/intel/common/Makefile.inc
M src/southbridge/intel/fsp_rangeley/Kconfig
M src/southbridge/intel/i82801gx/Kconfig
M src/southbridge/intel/i82801ix/Kconfig
M src/southbridge/intel/i82801jx/Kconfig
M src/southbridge/intel/ibexpeak/Kconfig
M src/southbridge/intel/lynxpoint/Kconfig
9 files changed, 17 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/33200/5

[Arthur Heymans (Code Review)]

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33200

to look at the new patch set (#6).

Change subject: sb/intel/common: Make linking pmbase.c conditional
......................................................................

sb/intel/common: Make linking pmbase.c conditional

Change-Id: I6a7cd96699dbeb42a53bf1d25db1bcf93e416e0f
Signed-off-by: Arthur Heymans 
---
M src/southbridge/intel/bd82x6x/Kconfig
M src/southbridge/intel/common/Kconfig
M src/southbridge/intel/common/Makefile.inc
M src/southbridge/intel/fsp_rangeley/Kconfig
M src/southbridge/intel/i82801gx/Kconfig
M src/southbridge/intel/i82801ix/Kconfig
M src/southbridge/intel/i82801jx/Kconfig
M src/southbridge/intel/ibexpeak/Kconfig
M src/southbridge/intel/lynxpoint/Kconfig
9 files changed, 17 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/33200/6

[Arthur Heymans (Code Review)]

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33200

to look at the new patch set (#7).

Change subject: sb/intel/common: Make linking pmbase.c conditional
......................................................................

sb/intel/common: Make linking pmbase.c conditional

Change-Id: I6a7cd96699dbeb42a53bf1d25db1bcf93e416e0f
Signed-off-by: Arthur Heymans 
---
M src/southbridge/intel/bd82x6x/Kconfig
M src/southbridge/intel/common/Kconfig
M src/southbridge/intel/common/Makefile.inc
M src/southbridge/intel/fsp_rangeley/Kconfig
M src/southbridge/intel/i82801gx/Kconfig
M src/southbridge/intel/i82801ix/Kconfig
M src/southbridge/intel/i82801jx/Kconfig
M src/southbridge/intel/ibexpeak/Kconfig
M src/southbridge/intel/lynxpoint/Kconfig
9 files changed, 17 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/33200/7

[Arthur Heymans (Code Review)]

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33200

to look at the new patch set (#9).

Change subject: sb/intel/common: Make linking pmbase.c conditional
......................................................................

sb/intel/common: Make linking pmbase.c conditional

Change-Id: I6a7cd96699dbeb42a53bf1d25db1bcf93e416e0f
Signed-off-by: Arthur Heymans 
---
M src/southbridge/intel/bd82x6x/Kconfig
M src/southbridge/intel/common/Kconfig
M src/southbridge/intel/common/Makefile.inc
M src/southbridge/intel/fsp_rangeley/Kconfig
M src/southbridge/intel/i82801gx/Kconfig
M src/southbridge/intel/i82801ix/Kconfig
M src/southbridge/intel/i82801jx/Kconfig
M src/southbridge/intel/ibexpeak/Kconfig
M src/southbridge/intel/lynxpoint/Kconfig
9 files changed, 16 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/33200/9

[Arthur Heymans (Code Review)]

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33200

to look at the new patch set (#10).

Change subject: sb/intel/common: Make linking pmbase.c conditional
......................................................................

sb/intel/common: Make linking pmbase.c conditional

Change-Id: I6a7cd96699dbeb42a53bf1d25db1bcf93e416e0f
Signed-off-by: Arthur Heymans 
---
M src/southbridge/intel/bd82x6x/Kconfig
M src/southbridge/intel/common/Kconfig
M src/southbridge/intel/common/Makefile.inc
M src/southbridge/intel/fsp_rangeley/Kconfig
M src/southbridge/intel/i82801gx/Kconfig
M src/southbridge/intel/i82801ix/Kconfig
M src/southbridge/intel/i82801jx/Kconfig
M src/southbridge/intel/ibexpeak/Kconfig
M src/southbridge/intel/lynxpoint/Kconfig
9 files changed, 16 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/33200/10

[Arthur Heymans (Code Review)]

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33200

to look at the new patch set (#11).

Change subject: sb/intel/common: Make linking pmbase.c conditional
......................................................................

sb/intel/common: Make linking pmbase.c conditional

Change-Id: I6a7cd96699dbeb42a53bf1d25db1bcf93e416e0f
Signed-off-by: Arthur Heymans 
---
M src/southbridge/intel/bd82x6x/Kconfig
M src/southbridge/intel/common/Kconfig
M src/southbridge/intel/common/Makefile.inc
M src/southbridge/intel/fsp_rangeley/Kconfig
M src/southbridge/intel/i82801gx/Kconfig
M src/southbridge/intel/i82801ix/Kconfig
M src/southbridge/intel/i82801jx/Kconfig
M src/southbridge/intel/ibexpeak/Kconfig
M src/southbridge/intel/lynxpoint/Kconfig
9 files changed, 15 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/33200/11

Change in coreboot[master]: sb/intel/common: Make linking pmbase.c conditional

[Arthur Heymans (Code Review)]

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33200

to look at the new patch set (#13).

Change subject: sb/intel/common: Make linking pmbase.c conditional
......................................................................

sb/intel/common: Make linking pmbase.c conditional

Change-Id: I6a7cd96699dbeb42a53bf1d25db1bcf93e416e0f
Signed-off-by: Arthur Heymans 
---
M src/southbridge/intel/bd82x6x/Kconfig
M src/southbridge/intel/common/Kconfig
M src/southbridge/intel/common/Makefile.inc
M src/southbridge/intel/fsp_rangeley/Kconfig
M src/southbridge/intel/i82801gx/Kconfig
M src/southbridge/intel/i82801ix/Kconfig
M src/southbridge/intel/i82801jx/Kconfig
M src/southbridge/intel/ibexpeak/Kconfig
M src/southbridge/intel/lynxpoint/Kconfig
9 files changed, 16 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/33200/13

Change in coreboot[master]: sb/intel/common: Make linking pmbase.c conditional

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33200 )

Change subject: sb/intel/common: Make linking pmbase.c conditional
......................................................................

Patch Set 14: Code-Review+2

Change in coreboot[master]: sb/intel/common: Make linking pmbase.c conditional

[Arthur Heymans (Code Review)]

Hello Patrick Rudolph, build bot (Jenkins), David Guckian, Patrick Georgi, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33200

to look at the new patch set (#16).

Change subject: sb/intel/common: Make linking pmbase.c conditional
......................................................................

sb/intel/common: Make linking pmbase.c conditional

Change-Id: I6a7cd96699dbeb42a53bf1d25db1bcf93e416e0f
Signed-off-by: Arthur Heymans 
---
M src/southbridge/intel/bd82x6x/Kconfig
M src/southbridge/intel/common/Kconfig
M src/southbridge/intel/common/Makefile.inc
M src/southbridge/intel/fsp_rangeley/Kconfig
M src/southbridge/intel/i82801gx/Kconfig
M src/southbridge/intel/i82801ix/Kconfig
M src/southbridge/intel/i82801jx/Kconfig
M src/southbridge/intel/ibexpeak/Kconfig
M src/southbridge/intel/lynxpoint/Kconfig
9 files changed, 16 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/33200/16

Change in coreboot[master]: sb/intel/common: Make linking pmbase.c conditional

[Arthur Heymans (Code Review)]

Hello Patrick Rudolph, build bot (Jenkins), David Guckian, Patrick Georgi, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33200

to look at the new patch set (#17).

Change subject: sb/intel/common: Make linking pmbase.c conditional
......................................................................

sb/intel/common: Make linking pmbase.c conditional

Change-Id: I6a7cd96699dbeb42a53bf1d25db1bcf93e416e0f
Signed-off-by: Arthur Heymans 
---
M src/southbridge/intel/bd82x6x/Kconfig
M src/southbridge/intel/common/Kconfig
M src/southbridge/intel/common/Makefile.inc
M src/southbridge/intel/fsp_rangeley/Kconfig
M src/southbridge/intel/i82801gx/Kconfig
M src/southbridge/intel/i82801ix/Kconfig
M src/southbridge/intel/i82801jx/Kconfig
M src/southbridge/intel/ibexpeak/Kconfig
M src/southbridge/intel/lynxpoint/Kconfig
9 files changed, 16 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/33200/17

Change in coreboot[master]: sb/intel/common: Make linking pmbase.c conditional

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33200 )

Change subject: sb/intel/common: Make linking pmbase.c conditional
......................................................................

Patch Set 17: Code-Review+2

Change in coreboot[master]: sb/intel/common: Make linking pmbase.c conditional

[Nico Huber (Code Review)]

Nico Huber has submitted this change. ( https://review.coreboot.org/c/coreboot/+/33200 )

Change subject: sb/intel/common: Make linking pmbase.c conditional
......................................................................

sb/intel/common: Make linking pmbase.c conditional

Change-Id: I6a7cd96699dbeb42a53bf1d25db1bcf93e416e0f
Signed-off-by: Arthur Heymans 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/33200
Reviewed-by: Patrick Rudolph 
Tested-by: build bot (Jenkins) 
---
M src/southbridge/intel/bd82x6x/Kconfig
M src/southbridge/intel/common/Kconfig
M src/southbridge/intel/common/Makefile.inc
M src/southbridge/intel/fsp_rangeley/Kconfig
M src/southbridge/intel/i82801gx/Kconfig
M src/southbridge/intel/i82801ix/Kconfig
M src/southbridge/intel/i82801jx/Kconfig
M src/southbridge/intel/ibexpeak/Kconfig
M src/southbridge/intel/lynxpoint/Kconfig
9 files changed, 16 insertions(+), 2 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Patrick Rudolph: Looks good to me, approved

diff --git a/src/southbridge/intel/bd82x6x/Kconfig b/src/southbridge/intel/bd82x6x/Kconfig
index fc3e9fc..f5b8b36 100644
--- a/src/southbridge/intel/bd82x6x/Kconfig
+++ b/src/southbridge/intel/bd82x6x/Kconfig
@@ -30,6 +30,7 @@
    select SOUTHBRIDGE_INTEL_COMMON_SMBUS
    select SOUTHBRIDGE_INTEL_COMMON_SPI
    select SOUTHBRIDGE_INTEL_COMMON_PMCLIB
+	select SOUTHBRIDGE_INTEL_COMMON_PMBASE
    select IOAPIC
    select HAVE_USBDEBUG_OPTIONS
    select HAVE_SMI_HANDLER
diff --git a/src/southbridge/intel/common/Kconfig b/src/southbridge/intel/common/Kconfig
index 31039b6..c5aaa80 100644
--- a/src/southbridge/intel/common/Kconfig
+++ b/src/southbridge/intel/common/Kconfig
@@ -9,6 +9,11 @@
 config SOUTHBRIDGE_INTEL_COMMON_PMCLIB
    def_bool n
    depends on SOUTHBRIDGE_INTEL_COMMON
+	depends on SOUTHBRIDGE_INTEL_COMMON_PMBASE
+
+config SOUTHBRIDGE_INTEL_COMMON_PMBASE
+	def_bool n
+	depends on SOUTHBRIDGE_INTEL_COMMON

config SOUTHBRIDGE_INTEL_COMMON_GPIO
    def_bool n
@@ -36,6 +41,7 @@
    def_bool n
    select HAVE_POWER_STATE_AFTER_FAILURE
    select HAVE_POWER_STATE_PREVIOUS_AFTER_FAILURE
+	select SOUTHBRIDGE_INTEL_COMMON_PMBASE

config SOUTHBRIDGE_INTEL_COMMON_ACPI_MADT
    bool
@@ -78,6 +84,7 @@
 config SOUTHBRIDGE_INTEL_COMMON_WATCHDOG
    bool
    depends on SOUTHBRIDGE_INTEL_COMMON
+	depends on SOUTHBRIDGE_INTEL_COMMON_PMBASE

if SOUTHBRIDGE_INTEL_COMMON_FINALIZE

diff --git a/src/southbridge/intel/common/Makefile.inc b/src/southbridge/intel/common/Makefile.inc
index e5a5a0c..5ca7daf 100644
--- a/src/southbridge/intel/common/Makefile.inc
+++ b/src/southbridge/intel/common/Makefile.inc
@@ -27,8 +27,8 @@

ifeq ($(CONFIG_SOUTHBRIDGE_INTEL_COMMON),y)

-all-y += pmbase.c
-smm-y += pmbase.c
+all-$(CONFIG_SOUTHBRIDGE_INTEL_COMMON_PMBASE) += pmbase.c
+smm-$(CONFIG_SOUTHBRIDGE_INTEL_COMMON_PMBASE) += pmbase.c

bootblock-$(CONFIG_USBDEBUG) += usb_debug.c
 romstage-$(CONFIG_USBDEBUG) += usb_debug.c
diff --git a/src/southbridge/intel/fsp_rangeley/Kconfig b/src/southbridge/intel/fsp_rangeley/Kconfig
index 4526cb3..3460ea6 100644
--- a/src/southbridge/intel/fsp_rangeley/Kconfig
+++ b/src/southbridge/intel/fsp_rangeley/Kconfig
@@ -32,6 +32,7 @@
    select SOUTHBRIDGE_INTEL_COMMON
    select SOUTHBRIDGE_INTEL_COMMON_SMBUS
    select SOUTHBRIDGE_INTEL_COMMON_WATCHDOG
+	select SOUTHBRIDGE_INTEL_COMMON_PMBASE

config EHCI_BAR
    hex
diff --git a/src/southbridge/intel/i82801gx/Kconfig b/src/southbridge/intel/i82801gx/Kconfig
index 2d6e938..5053a1f 100644
--- a/src/southbridge/intel/i82801gx/Kconfig
+++ b/src/southbridge/intel/i82801gx/Kconfig
@@ -26,6 +26,7 @@
    select SOUTHBRIDGE_INTEL_COMMON_SMBUS
    select SOUTHBRIDGE_INTEL_COMMON_SPI
    select SOUTHBRIDGE_INTEL_COMMON_PMCLIB
+	select SOUTHBRIDGE_INTEL_COMMON_PMBASE
    select HAVE_INTEL_CHIPSET_LOCKDOWN
    select SOUTHBRIDGE_INTEL_COMMON_RCBA_PIRQ
    select INTEL_HAS_TOP_SWAP
diff --git a/src/southbridge/intel/i82801ix/Kconfig b/src/southbridge/intel/i82801ix/Kconfig
index 5e9f513..1d51f43 100644
--- a/src/southbridge/intel/i82801ix/Kconfig
+++ b/src/southbridge/intel/i82801ix/Kconfig
@@ -20,6 +20,7 @@
    select SOUTHBRIDGE_INTEL_COMMON_SMBUS
    select SOUTHBRIDGE_INTEL_COMMON_SPI if !BOARD_EMULATION_QEMU_X86_Q35
    select SOUTHBRIDGE_INTEL_COMMON_RCBA_PIRQ
+	select SOUTHBRIDGE_INTEL_COMMON_PMBASE
    select IOAPIC
    select HAVE_USBDEBUG
    select USE_WATCHDOG_ON_BOOT
diff --git a/src/southbridge/intel/i82801jx/Kconfig b/src/southbridge/intel/i82801jx/Kconfig
index b423eca..430adf9 100644
--- a/src/southbridge/intel/i82801jx/Kconfig
+++ b/src/southbridge/intel/i82801jx/Kconfig
@@ -21,6 +21,7 @@
    select SOUTHBRIDGE_INTEL_COMMON_SPI
    select SOUTHBRIDGE_INTEL_COMMON_RCBA_PIRQ
    select SOUTHBRIDGE_INTEL_COMMON_PMCLIB
+	select SOUTHBRIDGE_INTEL_COMMON_PMBASE
    select IOAPIC
    select HAVE_USBDEBUG
    select USE_WATCHDOG_ON_BOOT
diff --git a/src/southbridge/intel/ibexpeak/Kconfig b/src/southbridge/intel/ibexpeak/Kconfig
index 5757a49..620736c 100644
--- a/src/southbridge/intel/ibexpeak/Kconfig
+++ b/src/southbridge/intel/ibexpeak/Kconfig
@@ -34,6 +34,7 @@
    select SOUTHBRIDGE_INTEL_COMMON_SPI
    select SOUTHBRIDGE_INTEL_COMMON_SMM
    select SOUTHBRIDGE_INTEL_COMMON_PMCLIB
+	select SOUTHBRIDGE_INTEL_COMMON_PMBASE
    select HAVE_USBDEBUG_OPTIONS
    select COMMON_FADT
    select ACPI_SATA_GENERATOR
diff --git a/src/southbridge/intel/lynxpoint/Kconfig b/src/southbridge/intel/lynxpoint/Kconfig
index 67e20be..2c28940 100644
--- a/src/southbridge/intel/lynxpoint/Kconfig
+++ b/src/southbridge/intel/lynxpoint/Kconfig
@@ -27,6 +27,7 @@
    select SOUTHBRIDGE_INTEL_COMMON_ACPI_MADT
    select SOUTHBRIDGE_INTEL_COMMON_FINALIZE
    select SOUTHBRIDGE_INTEL_COMMON_PMCLIB
+	select SOUTHBRIDGE_INTEL_COMMON_PMBASE
    select IOAPIC
    select HAVE_SMI_HANDLER
    select HAVE_USBDEBUG_OPTIONS