Change in coreboot[master]: mb/google/volteer/variants/volteer2: Turn I2C2 bus freq closer to 400...
Johnny Li has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47558 )
Change subject: mb/google/volteer/variants/volteer2: Turn I2C2 bus freq closer to 400 kHz for WLAN ......................................................................
mb/google/volteer/variants/volteer2: Turn I2C2 bus freq closer to 400 kHz for WLAN
The current I2C2 bus frequency is 344 kHZ, which does not meet the spec. This change updates scl_lcnt, scl_hcnt, sda_hold value for I2C2 to bring the bus frequency closer to 400 kHz.
BUG=b:153588771 TEST=Verified that I2C2 frequency is 380 kHz.
Signed-off-by: Johnny Li johnny_li@wistron.corp-partner.google.com Change-Id: I96fa5ed586de41324733ac7537b6bd73f39fc176 --- M src/mainboard/google/volteer/variants/volteer2/overridetree.cb 1 file changed, 7 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/47558/1
diff --git a/src/mainboard/google/volteer/variants/volteer2/overridetree.cb b/src/mainboard/google/volteer/variants/volteer2/overridetree.cb index e4da0e6..4678d26 100644 --- a/src/mainboard/google/volteer/variants/volteer2/overridetree.cb +++ b/src/mainboard/google/volteer/variants/volteer2/overridetree.cb @@ -36,6 +36,13 @@ }, .i2c[2] = { .speed = I2C_SPEED_FAST, + .speed_config[0] = { + .speed = I2C_SPEED_FAST, + .scl_lcnt = 163, + .scl_hcnt = 75, + .sda_hold = 36, + }, + }, .i2c[3] = { .speed = I2C_SPEED_FAST,
Johnny Li has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/47558 )
Change subject: mb/google/volteer/variants/volteer2: Turn I2C2 bus freq closer to 400 kHz for WLAN ......................................................................
mb/google/volteer/variants/volteer2: Turn I2C2 bus freq closer to 400 kHz for WLAN
The current I2C2 bus frequency is 344 kHZ, which does not meet the spec. This change updates scl_lcnt, scl_hcnt, sda_hold value for I2C2 to bring the bus frequency closer to 400 kHz.
BUG=b:153588771 TEST=Verified that I2C2 frequency is 380 kHz.
Signed-off-by: Johnny Li johnny_li@wistron.corp-partner.google.com Change-Id: I96fa5ed586de41324733ac7537b6bd73f39fc176 --- M src/mainboard/google/volteer/variants/volteer2/overridetree.cb 1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/47558/2
Johnny Li has removed Terry Chen from this change. ( https://review.coreboot.org/c/coreboot/+/47558 )
Change subject: mb/google/volteer/variants/volteer2: Turn I2C2 bus freq closer to 400 kHz for WLAN ......................................................................
Removed reviewer Terry Chen.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47558 )
Change subject: mb/google/volteer/variants/volteer2: Turn I2C2 bus freq closer to 400 kHz for WLAN ......................................................................
Patch Set 2: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/47558/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/47558/2//COMMIT_MSG@7 PS2, Line 7: mb/google/volteer/variants/volteer2: Turn I2C2 bus freq closer to 400 kHz for WLAN suggestion: mb/google/volteer: Tune Volteer2 I2C2 bus frequency
Hello build bot (Jenkins), Caveh Jalali, Tim Wawrzynczak,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/47558
to look at the new patch set (#3).
Change subject: mb/google/volteer/variants/volteer2: Tune Volteer2 I2C2 bus frequency closer to 400 kHz for WLAN ......................................................................
mb/google/volteer/variants/volteer2: Tune Volteer2 I2C2 bus frequency closer to 400 kHz for WLAN
The current I2C2 bus frequency is 344 kHZ, which does not meet the spec. This change updates scl_lcnt, scl_hcnt, sda_hold value for I2C2 to bring the bus frequency closer to 400 kHz.
BUG=b:153588771 TEST=Verified that I2C2 frequency is 380 kHz.
Signed-off-by: Johnny Li johnny_li@wistron.corp-partner.google.com Change-Id: I96fa5ed586de41324733ac7537b6bd73f39fc176 --- M src/mainboard/google/volteer/variants/volteer2/overridetree.cb 1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/47558/3
Johnny Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47558 )
Change subject: mb/google/volteer/variants/volteer2: Tune Volteer2 I2C2 bus frequency closer to 400 kHz for WLAN ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47558/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/47558/2//COMMIT_MSG@7 PS2, Line 7: mb/google/volteer/variants/volteer2: Turn I2C2 bus freq closer to 400 kHz for WLAN
suggestion: […]
done
Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47558 )
Change subject: mb/google/volteer/variants/volteer2: Tune Volteer2 I2C2 bus frequency closer to 400 kHz for WLAN ......................................................................
Patch Set 3: Code-Review+1
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47558 )
Change subject: mb/google/volteer/variants/volteer2: Tune Volteer2 I2C2 bus frequency closer to 400 kHz for WLAN ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47558/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/47558/3//COMMIT_MSG@7 PS3, Line 7: closer to 400 kHz for WLAN This is redundant, and also makes the commit summary too long (keep it to 72 chars or less, please), so just remove the highlighted section here
Hello build bot (Jenkins), Caveh Jalali, Tim Wawrzynczak,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/47558
to look at the new patch set (#4).
Change subject: mb/google/volteer/variants/volteer2: Tune Volteer2 I2C2 bus frequency ......................................................................
mb/google/volteer/variants/volteer2: Tune Volteer2 I2C2 bus frequency
The current I2C2 bus frequency is 344 kHZ, which does not meet the spec. This change updates scl_lcnt, scl_hcnt, sda_hold value for I2C2 to bring the bus frequency closer to 400 kHz.
BUG=b:153588771 TEST=Verified that I2C2 frequency is 380 kHz.
Signed-off-by: Johnny Li johnny_li@wistron.corp-partner.google.com Change-Id: I96fa5ed586de41324733ac7537b6bd73f39fc176 --- M src/mainboard/google/volteer/variants/volteer2/overridetree.cb 1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/47558/4
Johnny Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47558 )
Change subject: mb/google/volteer/variants/volteer2: Tune Volteer2 I2C2 bus frequency ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47558/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/47558/3//COMMIT_MSG@7 PS3, Line 7: closer to 400 kHz for WLAN
This is redundant, and also makes the commit summary too long (keep it to 72 chars or less, please), […]
done
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47558 )
Change subject: mb/google/volteer/variants/volteer2: Tune Volteer2 I2C2 bus frequency ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/47558/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/47558/2//COMMIT_MSG@7 PS2, Line 7: mb/google/volteer/variants/volteer2: Turn I2C2 bus freq closer to 400 kHz for WLAN
done
Done
https://review.coreboot.org/c/coreboot/+/47558/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/47558/3//COMMIT_MSG@7 PS3, Line 7: closer to 400 kHz for WLAN
done
Done
Tim Wawrzynczak has submitted this change. ( https://review.coreboot.org/c/coreboot/+/47558 )
Change subject: mb/google/volteer/variants/volteer2: Tune Volteer2 I2C2 bus frequency ......................................................................
mb/google/volteer/variants/volteer2: Tune Volteer2 I2C2 bus frequency
The current I2C2 bus frequency is 344 kHZ, which does not meet the spec. This change updates scl_lcnt, scl_hcnt, sda_hold value for I2C2 to bring the bus frequency closer to 400 kHz.
BUG=b:153588771 TEST=Verified that I2C2 frequency is 380 kHz.
Signed-off-by: Johnny Li johnny_li@wistron.corp-partner.google.com Change-Id: I96fa5ed586de41324733ac7537b6bd73f39fc176 Reviewed-on: https://review.coreboot.org/c/coreboot/+/47558 Reviewed-by: Caveh Jalali caveh@chromium.org Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/volteer/variants/volteer2/overridetree.cb 1 file changed, 6 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Caveh Jalali: Looks good to me, but someone else must approve Tim Wawrzynczak: Looks good to me, approved
diff --git a/src/mainboard/google/volteer/variants/volteer2/overridetree.cb b/src/mainboard/google/volteer/variants/volteer2/overridetree.cb index e4da0e6..72cb79a 100644 --- a/src/mainboard/google/volteer/variants/volteer2/overridetree.cb +++ b/src/mainboard/google/volteer/variants/volteer2/overridetree.cb @@ -36,6 +36,12 @@ }, .i2c[2] = { .speed = I2C_SPEED_FAST, + .speed_config[0] = { + .speed = I2C_SPEED_FAST, + .scl_lcnt = 163, + .scl_hcnt = 75, + .sda_hold = 36, + }, }, .i2c[3] = { .speed = I2C_SPEED_FAST,
-
Caveh Jalali (Code Review) -
Johnny Li (Code Review)
-
Tim Wawrzynczak (Code Review)