Change in coreboot[master]: mb/google/octopus/variants/bobba: Add G2Touch touchscreen support

[Sheng-Liang Pan (Code Review)]

Sheng-Liang Pan has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46808 )

Change subject: mb/google/octopus/variants/bobba: Add G2Touch touchscreen support
......................................................................

mb/google/octopus/variants/bobba: Add G2Touch touchscreen support

Add G2Touch touchscreen support for bobba.

BUG=b:171636614
BRANCH=octopus
TEST=emerge-octopus coreboot chromeos-bootimage, and check touchscreen
work.

Signed-off-by: Pan Sheng-Liang 
Change-Id: Ia361a56c050d7cbd7325b3c09fc34d8707441cc4
---
M src/mainboard/google/octopus/variants/bobba/overridetree.cb
1 file changed, 14 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/46808/1

diff --git a/src/mainboard/google/octopus/variants/bobba/overridetree.cb b/src/mainboard/google/octopus/variants/bobba/overridetree.cb
index 20c376a..c3a63c7 100644
--- a/src/mainboard/google/octopus/variants/bobba/overridetree.cb
+++ b/src/mainboard/google/octopus/variants/bobba/overridetree.cb
@@ -210,6 +210,20 @@
    			register "has_power_resource" = "1"
    			device i2c 39 on end
    		end
+			chip drivers/i2c/hid
+				register "generic.hid" = ""GTCH7502""
+				register "generic.desc" = ""G2TOUCH Touchscreen""
+				register "generic.irq" = "ACPI_IRQ_EDGE_LOW(GPIO_212_IRQ)"
+				register "generic.probed" = "1"
+				register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_105)"
+				register "generic.reset_delay_ms" = "70"
+				register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_146)"
+				register "generic.enable_delay_ms" = "1"
+				register "generic.has_power_resource" = "1"
+				register "generic.disable_gpio_export_in_crs" = "1"
+				register "hid_desc_reg_offset" = "0x01"
+				device i2c 40 on end
+			end
    	end	# - I2C 7
    end

[Sheng-Liang Pan (Code Review)]

Sheng-Liang Pan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46808 )

Change subject: mb/google/octopus/variants/bobba: Add G2Touch touchscreen support
......................................................................

Patch Set 1: Code-Review+1

[Sheng-Liang Pan (Code Review)]

Hello Henry Sun, Marco Chen,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46808

to look at the new patch set (#2).

Change subject: mb/google/octopus/variants/bobba: Add G2Touch touchscreen support
......................................................................

mb/google/octopus/variants/bobba: Add G2Touch touchscreen support

Add G2Touch touchscreen support for bobba.

BUG=b:171636614, b:169730666
BRANCH=octopus
TEST=emerge-octopus coreboot chromeos-bootimage, and check touchscreen
work.

Signed-off-by: Pan Sheng-Liang 
Change-Id: Ia361a56c050d7cbd7325b3c09fc34d8707441cc4
---
M src/mainboard/google/octopus/variants/bobba/overridetree.cb
1 file changed, 14 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/46808/2

[Marco Chen (Code Review)]

Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46808 )

Change subject: mb/google/octopus/variants/bobba: Add G2Touch touchscreen support
......................................................................

Patch Set 2:

clarify difference between GTCH7502 and TGCH7503 in the issue.

[Sheng-Liang Pan (Code Review)]

Sheng-Liang Pan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46808 )

Change subject: mb/google/octopus/variants/bobba: Add G2Touch touchscreen support
......................................................................

Patch Set 2:
> Patch Set 2:
>
> clarify difference between GTCH7502 and TGCH7503 in the issue.

GTCH7502 is for 2IC model and GTCH7503 is for 3IC model, this is just our internal management rule, there is no other special reason.

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46808 )

Change subject: mb/google/octopus/variants/bobba: Add G2Touch touchscreen support
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/46808/2/src/mainboard/google/octopu... 
File src/mainboard/google/octopus/variants/bobba/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/46808/2/src/mainboard/google/octopu... 
PS2, Line 216: ACPI_IRQ_EDGE_LOW
I2C-HID devices are expected to use level-triggered interrupts.

[Marco Chen (Code Review)]

Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46808 )

Change subject: mb/google/octopus/variants/bobba: Add G2Touch touchscreen support
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/46808/2/src/mainboard/google/octopu... 
File src/mainboard/google/octopus/variants/bobba/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/46808/2/src/mainboard/google/octopu... 
PS2, Line 216: ACPI_IRQ_EDGE_LOW
> I2C-HID devices are expected to use level-triggered interrupts.

Please refer to commit [1] where mentioned that The first release of the HID over I2C specification mentioned that the level trigger needed to be active low. In the latest
version of the specification, there is no such explicit mention.

[1] https://chromium.googlesource.com/chromiumos/third_party/kernel/+/00f7fea5da...

[Marco Chen (Code Review)]

Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46808 )

Change subject: mb/google/octopus/variants/bobba: Add G2Touch touchscreen support
......................................................................

Patch Set 2: Code-Review+1

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46808 )

Change subject: mb/google/octopus/variants/bobba: Add G2Touch touchscreen support
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/46808/2/src/mainboard/google/octopu... 
File src/mainboard/google/octopus/variants/bobba/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/46808/2/src/mainboard/google/octopu... 
PS2, Line 216: ACPI_IRQ_EDGE_LOW
> Please refer to commit [1] where mentioned that The first release of the HID over I2C specification  […]

This is from the latest specification[1]:

"DEVICE is responsible to assert the interrupt line (level trigger interrupt required) when it has data.

DEVICE must keep the interrupt line asserted until the data has been fully read by the HOST. After this point, the DEVICE must de-assert the interrupt line if it has no more data to report to the HOST.

When the DEVICE has new data to report, it must repeat the process above."

Also, if you see "Updates between v0.91 and v1.0", it says:
"Level triggered interrupts changed to “required” from “recommended”. "

[1] http://download.microsoft.com/download/7/d/d/7dd44bb7-2a7a-4505-ac1c-7227d3d...

[Marco Chen (Code Review)]

Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46808 )

Change subject: mb/google/octopus/variants/bobba: Add G2Touch touchscreen support
......................................................................

Patch Set 2: -Code-Review

(1 comment)

https://review.coreboot.org/c/coreboot/+/46808/2/src/mainboard/google/octopu... 
File src/mainboard/google/octopus/variants/bobba/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/46808/2/src/mainboard/google/octopu... 
PS2, Line 216: ACPI_IRQ_EDGE_LOW
> This is from the latest specification[1]: […]

Thanks for the info, Furquan. Learn from you.

[Sheng-Liang Pan (Code Review)]

Hello build bot (Jenkins), Furquan Shaikh, Henry Sun, Marco Chen, Marco Chen, Karthik Ramasubramanian,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46808

to look at the new patch set (#3).

Change subject: mb/google/octopus/variants/bobba: Add G2Touch touchscreen support
......................................................................

mb/google/octopus/variants/bobba: Add G2Touch touchscreen support

Add G2Touch touchscreen support for bobba.

BUG=b:171636614, b:169730666
BRANCH=octopus
TEST=emerge-octopus coreboot chromeos-bootimage, and check touchscreen
work.

Signed-off-by: Pan Sheng-Liang 
Change-Id: Ia361a56c050d7cbd7325b3c09fc34d8707441cc4
---
M src/mainboard/google/octopus/variants/bobba/overridetree.cb
1 file changed, 14 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/46808/3

[Sheng-Liang Pan (Code Review)]

Sheng-Liang Pan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46808 )

Change subject: mb/google/octopus/variants/bobba: Add G2Touch touchscreen support
......................................................................

Patch Set 3: Code-Review+1

(1 comment)

https://review.coreboot.org/c/coreboot/+/46808/2/src/mainboard/google/octopu... 
File src/mainboard/google/octopus/variants/bobba/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/46808/2/src/mainboard/google/octopu... 
PS2, Line 216: ACPI_IRQ_EDGE_LOW
> Thanks for the info, Furquan. Learn from you.

change to LEVEL-triggered

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46808 )

Change subject: mb/google/octopus/variants/bobba: Add G2Touch touchscreen support
......................................................................

Patch Set 3: Code-Review+2

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46808 )

Change subject: mb/google/octopus/variants/bobba: Add G2Touch touchscreen support
......................................................................

Patch Set 4:

Sheng-Liang - you will have to mark all your pending comments as resolved before gerrit allows submitting the change.

[Karthik Ramasubramanian (Code Review)]

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46808 )

Change subject: mb/google/octopus/variants/bobba: Add G2Touch touchscreen support
......................................................................

Patch Set 4: Code-Review+2

[Sheng-Liang Pan (Code Review)]

Sheng-Liang Pan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46808 )

Change subject: mb/google/octopus/variants/bobba: Add G2Touch touchscreen support
......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/46808/2/src/mainboard/google/octopu... 
File src/mainboard/google/octopus/variants/bobba/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/46808/2/src/mainboard/google/octopu... 
PS2, Line 216: ACPI_IRQ_EDGE_LOW
> change to LEVEL-triggered

mark as resolved

[Sheng-Liang Pan (Code Review)]

Sheng-Liang Pan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46808 )

Change subject: mb/google/octopus/variants/bobba: Add G2Touch touchscreen support
......................................................................

Patch Set 4:
> Patch Set 4:
>
> Sheng-Liang - you will have to mark all your pending comments as resolved before gerrit allows submitting the change.

Thank you for remind

[Furquan Shaikh (Code Review)]

Furquan Shaikh has submitted this change. ( https://review.coreboot.org/c/coreboot/+/46808 )

Change subject: mb/google/octopus/variants/bobba: Add G2Touch touchscreen support
......................................................................

mb/google/octopus/variants/bobba: Add G2Touch touchscreen support

Add G2Touch touchscreen support for bobba.

BUG=b:171636614, b:169730666
BRANCH=octopus
TEST=emerge-octopus coreboot chromeos-bootimage, and check touchscreen
work.

Signed-off-by: Pan Sheng-Liang 
Change-Id: Ia361a56c050d7cbd7325b3c09fc34d8707441cc4
Reviewed-on: https://review.coreboot.org/c/coreboot/+/46808
Tested-by: build bot (Jenkins) 
Reviewed-by: Karthik Ramasubramanian 
Reviewed-by: Furquan Shaikh 
---
M src/mainboard/google/octopus/variants/bobba/overridetree.cb
1 file changed, 14 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Furquan Shaikh: Looks good to me, approved
  Sheng-Liang Pan: Looks good to me, but someone else must approve
  Karthik Ramasubramanian: Looks good to me, approved

diff --git a/src/mainboard/google/octopus/variants/bobba/overridetree.cb b/src/mainboard/google/octopus/variants/bobba/overridetree.cb
index 662e6af..3c7187e 100644
--- a/src/mainboard/google/octopus/variants/bobba/overridetree.cb
+++ b/src/mainboard/google/octopus/variants/bobba/overridetree.cb
@@ -210,6 +210,20 @@
    			register "has_power_resource" = "1"
    			device i2c 39 on end
    		end
+			chip drivers/i2c/hid
+				register "generic.hid" = ""GTCH7502""
+				register "generic.desc" = ""G2TOUCH Touchscreen""
+				register "generic.irq" = "ACPI_IRQ_LEVEL_LOW(GPIO_212_IRQ)"
+				register "generic.probed" = "1"
+				register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_105)"
+				register "generic.reset_delay_ms" = "70"
+				register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_146)"
+				register "generic.enable_delay_ms" = "1"
+				register "generic.has_power_resource" = "1"
+				register "generic.disable_gpio_export_in_crs" = "1"
+				register "hid_desc_reg_offset" = "0x01"
+				device i2c 40 on end
+			end
    	end	# - I2C 7
    end