Attention is currently required from: Stefan Ott, Bill XIE, Alexander Couzens.
Hello Stefan Ott, build bot (Jenkins), Arthur Heymans, Alexander Couzens,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/74181
to look at the new patch set (#2).
Change subject: mb/lenovo/x200: Read EDID in mainboard_vbt_filename() ......................................................................
mb/lenovo/x200: Read EDID in mainboard_vbt_filename()
mainboard_vbt_filename() used to assume that it is called after a call to get_blc_pwm_freq_value() with a valid parameter, but currently it is the first call of get_blc_pwm_freq_value(NULL), and will return 0, making "data_led.vbt" is always returned, regardless of the actual type of the panel.
Combined with the previous commit, in this commit mainboard_vbt_filename() will explicitly read EDID string via get_edid_str() and use this string to call get_blc_pwm_freq_value().
This will resolve https://ticket.coreboot.org/issues/475 .
Tested on my x200s with LTD121EQ3B, and x200 with LTD121EQ3B.
Signed-off-by: Bill XIE persmule@hardenedlinux.org Change-Id: I2e080b29321b6989d1f26b6c67876b3d703042f4 --- M src/mainboard/lenovo/x200/blc.c 1 file changed, 27 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/74181/2