Change in coreboot[master]: mb/google/octopus: do LPC/eSPI pad configuration at board-level

[Michael Niewöhner (Code Review)]

Attention is currently required from: Nico Huber, Karthik Ramasubramanian.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49411 )

Change subject: mb/google/octopus: do LPC/eSPI pad configuration at board-level
......................................................................

Patch Set 1:

(2 comments)

File src/mainboard/google/octopus/bootblock.c:

https://review.coreboot.org/c/coreboot/+/49411/comment/09de4f98_68556d48 
PS1, Line 13: 	pads = variant_early_bootblock_gpio_table(&num);
> The default contents are specific to make the next variant-independent […]

Oh, I thought I had commented that alreay... strange. Well, I don't think it's required to make it weak. Was just done for consistency across all the google gpio tables where all except a few iirc are weak. Some other boards do override the bootblock gpio table in their variants but for this board it's currently not required. So I'd make it non-weak. If it's required later, it can easily be added.

File src/mainboard/google/octopus/variants/baseboard/include/baseboard/variants.h:

https://review.coreboot.org/c/coreboot/+/49411/comment/5da0740b_ad40d521 
PS1, Line 15: const struct pad_config *variant_early_bootblock_gpio_table(size_t *num);
            : const struct pad_config *variant_early_gpio_table(size_t *num);
> Sorry, was typing lazy. With `early` I meant `variant_early_gpio_table`. […]

Agreed. I'll push a patch that renames them all at once. That's not a big deal.