Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50480 )
Change subject: drivers/spi: Stop using a variable-length array
......................................................................
Patch Set 3:
(1 comment)
File src/drivers/spi/spi_flash_internal.h:
https://review.coreboot.org/c/coreboot/+/50480/comment/532576bc_221a3718
PS2, Line 27: #define MAX_FLASH_CMD_DATA_SIZE 256
I'm not sure how I would use a _Static_assert to check this.
I'll see how to do it in a separate commit.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50480
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib630bff1b496bc276616989d4506a3c96f242e26
Gerrit-Change-Number: 50480
Gerrit-PatchSet: 3
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 15 Feb 2021 09:57:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Georgi
pgeorgi@google.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment