Change in coreboot[master]: src/mainboard/herobrine: Initialize SPI FW for EC and TPM - coreboot-gerrit

27 Jul 2021


      Attention is currently required from: Shelley Chen, Ravi kumar, mturney mturney, Julius Werner.
Rajesh Patil has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50581 )
Change subject: src/mainboard/herobrine: Initialize SPI FW for EC and TPM
......................................................................
Patch Set 60:
(1 comment)
File src/mainboard/google/herobrine/Kconfig:
https://review.coreboot.org/c/coreboot/+/50581/comment/8970a94c_b4b79a21 
PS58, Line 55: 0xA
...
Also, I just looked up the EC QUP # and it seems like it's supposed to be 8: […]
i will check with hardware team and update to you
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/50581
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8cbdd1d59a0166688d52d61646db1b6764879a7c
Gerrit-Change-Number: 50581
Gerrit-PatchSet: 60
Gerrit-Owner: Ravi kumar rbokka@codeaurora.org
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Shelley Chen shchen@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Reviewer: mturney mturney mturney@codeaurora.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-CC: Rajesh Patil rajpat@qualcomm.corp-partner.google.com
Gerrit-CC: Ravi Kumar Bokka c_rbokka@qualcomm.corp-partner.google.com
Gerrit-Attention: Shelley Chen shchen@google.com
Gerrit-Attention: Ravi kumar rbokka@codeaurora.org
Gerrit-Attention: mturney mturney mturney@codeaurora.org
Gerrit-Attention: Julius Werner jwerner@chromium.org
Gerrit-Comment-Date: Tue, 27 Jul 2021 18:32:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Shelley Chen shchen@google.com
Gerrit-MessageType: comment