Attention is currently required from: Tim Wawrzynczak, Eric Lai.
Tarun Tuli has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63984 )
Change subject: soc/intel/alderlake: Add missing ACPI device path names
......................................................................
Patch Set 5:
(1 comment)
File src/soc/intel/alderlake/chip.c:
https://review.coreboot.org/c/coreboot/+/63984/comment/432bcf12_d1cc001c
PS5, Line 78: case SA_DEVFN_DPTF: return "DPTF";
Interesting, should we change to DTT now? In EDS, Dynamica Tuning Technology (D4:F0) but pci_devs. […]
Hi Eric. We can definitely update the naming of the defines/strings if this isn't current anymore. Is it worth perhaps doing a sanity of them all? Perhaps best in a separate submission?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63984
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I37d6dd5df921c931af72dd469c3f4067c61b0df3
Gerrit-Change-Number: 63984
Gerrit-PatchSet: 5
Gerrit-Owner: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Comment-Date: Tue, 03 May 2022 12:49:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-MessageType: comment