Change in ...coreboot[master]: drivers/emulation/qemu_debugcon: Don't use CAR_GLOBAL

[Arthur Heymans (Code Review)]

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33000

Change subject: drivers/emulation/qemu_debugcon: Don't use CAR_GLOBAL
......................................................................

drivers/emulation/qemu_debugcon: Don't use CAR_GLOBAL

This platform uses NO_CAR_GLOBAL_MIGRATION.

Change-Id: Idc9434e5a1a8bc5ed76a9f80c9a7cfba2fd474c0
Signed-off-by: Arthur Heymans 
---
M src/drivers/emulation/qemu/qemu_debugcon.c
1 file changed, 2 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/33000/1

diff --git a/src/drivers/emulation/qemu/qemu_debugcon.c b/src/drivers/emulation/qemu/qemu_debugcon.c
index 3807524..a4715d1 100644
--- a/src/drivers/emulation/qemu/qemu_debugcon.c
+++ b/src/drivers/emulation/qemu/qemu_debugcon.c
@@ -17,14 +17,13 @@
 #include <console/console.h>
 #include <console/qemu_debugcon.h>
 #include <arch/io.h>
-#include <arch/early_variables.h>

-static int qemu_debugcon_detected CAR_GLOBAL;
+static int qemu_debugcon_detected;

void qemu_debugcon_init(void)
 {
    int detected = (inb(CONFIG_CONSOLE_QEMU_DEBUGCON_PORT) == 0xe9);
-	car_set_var(qemu_debugcon_detected, detected);
+	qemu_debugcon_detected = detected;
    printk(BIOS_INFO, "QEMU debugcon %s [port 0x%x]\n",
           detected ? "detected" : "not found",
           CONFIG_CONSOLE_QEMU_DEBUGCON_PORT);

[Arthur Heymans (Code Review)]

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33000

to look at the new patch set (#5).

Change subject: drivers/emulation/qemu_debugcon: Don't use CAR_GLOBAL
......................................................................

drivers/emulation/qemu_debugcon: Don't use CAR_GLOBAL

This platform uses NO_CAR_GLOBAL_MIGRATION.

Change-Id: Idc9434e5a1a8bc5ed76a9f80c9a7cfba2fd474c0
Signed-off-by: Arthur Heymans 
---
M src/drivers/emulation/qemu/qemu_debugcon.c
1 file changed, 3 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/33000/5

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33000 )

Change subject: drivers/emulation/qemu_debugcon: Don't use CAR_GLOBAL
......................................................................

Patch Set 5: Code-Review+2

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/33000 )

Change subject: drivers/emulation/qemu_debugcon: Don't use CAR_GLOBAL
......................................................................

drivers/emulation/qemu_debugcon: Don't use CAR_GLOBAL

This platform uses NO_CAR_GLOBAL_MIGRATION.

Change-Id: Idc9434e5a1a8bc5ed76a9f80c9a7cfba2fd474c0
Signed-off-by: Arthur Heymans 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/33000
Tested-by: build bot (Jenkins) 
Reviewed-by: Kyösti Mälkki 
---
M src/drivers/emulation/qemu/qemu_debugcon.c
1 file changed, 3 insertions(+), 4 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Kyösti Mälkki: Looks good to me, approved

diff --git a/src/drivers/emulation/qemu/qemu_debugcon.c b/src/drivers/emulation/qemu/qemu_debugcon.c
index 3807524..b040bd8 100644
--- a/src/drivers/emulation/qemu/qemu_debugcon.c
+++ b/src/drivers/emulation/qemu/qemu_debugcon.c
@@ -17,14 +17,13 @@
 #include <console/console.h>
 #include <console/qemu_debugcon.h>
 #include <arch/io.h>
-#include <arch/early_variables.h>

-static int qemu_debugcon_detected CAR_GLOBAL;
+static int qemu_debugcon_detected;

void qemu_debugcon_init(void)
 {
    int detected = (inb(CONFIG_CONSOLE_QEMU_DEBUGCON_PORT) == 0xe9);
-	car_set_var(qemu_debugcon_detected, detected);
+	qemu_debugcon_detected = detected;
    printk(BIOS_INFO, "QEMU debugcon %s [port 0x%x]\n",
           detected ? "detected" : "not found",
           CONFIG_CONSOLE_QEMU_DEBUGCON_PORT);
@@ -32,6 +31,6 @@

void qemu_debugcon_tx_byte(unsigned char data)
 {
-	if (car_get_var(qemu_debugcon_detected) != 0)
+	if (qemu_debugcon_detected != 0)
    	outb(data, CONFIG_CONSOLE_QEMU_DEBUGCON_PORT);
 }