Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48801 )
Change subject: mb/clevo/cml-u: move gpio early init to bootblock_mainboard_early_init ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48801/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/48801/2//COMMIT_MSG@10 PS2, Line 10: after gpio configuration in : common code got dropped.
Why does this depend on the common GPIO code changes?
As soon ("after") the common code got dropped, the pads will be configured by mainboard code, which runs later. This patch makes it being initialized again earlier.
Cometlake is not even handled in your changes. So I think you can remove that and rebase on CB:48328.
This *is* based on CB:48328.