Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39944 )
Change subject: mb/google/auron: Add support for ACPI backlight controls ......................................................................
mb/google/auron: Add support for ACPI backlight controls
Test: build/boot lulu and samus variants, verify backlight control functional under Windows 10.
Change-Id: I4725fdea5206ae03df14a8b07e51fdf09f1edebd Signed-off-by: Matt DeVillier matt.devillier@gmail.com --- M src/mainboard/google/auron/devicetree.cb M src/mainboard/google/auron/dsdt.asl 2 files changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/39944/1
diff --git a/src/mainboard/google/auron/devicetree.cb b/src/mainboard/google/auron/devicetree.cb index 35074b4..f28a508 100644 --- a/src/mainboard/google/auron/devicetree.cb +++ b/src/mainboard/google/auron/devicetree.cb @@ -1,5 +1,8 @@ chip soc/intel/broadwell
+ # IGD Displays + register "gfx" = "GMA_STATIC_DISPLAYS(0)" + # Enable eDP Hotplug with 6ms pulse register "gpu_dp_d_hotplug" = "0x06"
diff --git a/src/mainboard/google/auron/dsdt.asl b/src/mainboard/google/auron/dsdt.asl index f7c5000..a22dedd 100644 --- a/src/mainboard/google/auron/dsdt.asl +++ b/src/mainboard/google/auron/dsdt.asl @@ -38,6 +38,7 @@ { #include <soc/intel/broadwell/acpi/systemagent.asl> #include <soc/intel/broadwell/acpi/pch.asl> + #include <drivers/intel/gma/acpi/default_brightness_levels.asl> } }
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39944 )
Change subject: mb/google/auron: Add support for ACPI backlight controls ......................................................................
Patch Set 5: Code-Review+2
Matt DeVillier has submitted this change. ( https://review.coreboot.org/c/coreboot/+/39944 )
Change subject: mb/google/auron: Add support for ACPI backlight controls ......................................................................
mb/google/auron: Add support for ACPI backlight controls
Test: build/boot lulu and samus variants, verify backlight control functional under Windows 10.
Change-Id: I4725fdea5206ae03df14a8b07e51fdf09f1edebd Signed-off-by: Matt DeVillier matt.devillier@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/39944 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/google/auron/devicetree.cb M src/mainboard/google/auron/dsdt.asl 2 files changed, 4 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/mainboard/google/auron/devicetree.cb b/src/mainboard/google/auron/devicetree.cb index cabcdf0..a84aa98 100644 --- a/src/mainboard/google/auron/devicetree.cb +++ b/src/mainboard/google/auron/devicetree.cb @@ -1,5 +1,8 @@ chip soc/intel/broadwell
+ # IGD Displays + register "gfx" = "GMA_STATIC_DISPLAYS(0)" + # Enable eDP Hotplug with 6ms pulse register "gpu_dp_d_hotplug" = "0x06"
diff --git a/src/mainboard/google/auron/dsdt.asl b/src/mainboard/google/auron/dsdt.asl index f7c5000..a22dedd 100644 --- a/src/mainboard/google/auron/dsdt.asl +++ b/src/mainboard/google/auron/dsdt.asl @@ -38,6 +38,7 @@ { #include <soc/intel/broadwell/acpi/systemagent.asl> #include <soc/intel/broadwell/acpi/pch.asl> + #include <drivers/intel/gma/acpi/default_brightness_levels.asl> } }
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39944 )
Change subject: mb/google/auron: Add support for ACPI backlight controls ......................................................................
Patch Set 8:
Automatic boot test returned (PASS/FAIL/TOTAL): 3/0/3 Emulation targets: EMULATION_QEMU_X86_Q35 using payload TianoCore : SUCCESS : https://lava.9esec.io/r/2027 EMULATION_QEMU_X86_Q35 using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/2026 EMULATION_QEMU_X86_I440FX using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/2025
Please note: This test is under development and might not be accurate at all!
-
9elements QA (Code Review) -
Angel Pons (Code Review)
-
Matt DeVillier (Code Review)