Attention is currently required from: Jeff Daly, Stefan Reinauer, Angel Pons, Kyösti Mälkki.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60736 )
Change subject: util/ifdtool: Add additional regions for platforms that support them.
......................................................................
Patch Set 5:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/60736/comment/974a4101_3b90df44
PS1, Line 7: util/ifdtool: Add additional regions for platforms that support them.
Done
It came back. ;-)
Patchset:
PS5:
i seem to be missing the trick to fixing the (indirect ancestor) issue. […]
Please paste the comments you used. In this case, it probably means, that CB:60737 was once a parent in the same branch. Now you only pushed this change-set/commit and rebased it somehow, and you didn’t push the other one in the same branch. Due to the Change-Ids Gerrit knows, that they were once in the same branch, and, therefore, related.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60736
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I64cc1d787f15a01dff7db89218410228fd0082a6
Gerrit-Change-Number: 60736
Gerrit-PatchSet: 5
Gerrit-Owner: Jeff Daly
jeffd@silicom-usa.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jeff Daly
jeffd@silicom-usa.com
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Wed, 05 Jan 2022 22:54:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jeff Daly
jeffd@silicom-usa.com
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment