Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/76883?usp=email )
Change subject: drivers/uart/pl011: Fix regwidth ......................................................................
drivers/uart/pl011: Fix regwidth
Width of registers are always dwords on pl011, not bytes.
Signed-off-by: Arthur Heymans arthur@aheymans.xyz Change-Id: I955319d31bba5c0cd4d50f2b34111d51fea653ed Reviewed-on: https://review.coreboot.org/c/coreboot/+/76883 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Eric Lai eric_lai@quanta.corp-partner.google.com Reviewed-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-by: Paul Menzel paulepanter@mailbox.org --- M src/drivers/uart/pl011.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: Kyösti Mälkki: Looks good to me, approved build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Eric Lai: Looks good to me, approved
diff --git a/src/drivers/uart/pl011.c b/src/drivers/uart/pl011.c index 0661de1..64c279d 100644 --- a/src/drivers/uart/pl011.c +++ b/src/drivers/uart/pl011.c @@ -40,7 +40,7 @@ serial->type = LB_SERIAL_TYPE_MEMORY_MAPPED; serial->baseaddr = uart_platform_base(CONFIG_UART_FOR_CONSOLE); serial->baud = get_uart_baudrate(); - serial->regwidth = 1; + serial->regwidth = 4; serial->input_hertz = uart_platform_refclk();
return CB_SUCCESS;