Change in ...coreboot[master]: mb/lenovo/x60: Use system_reset()

List overview All Threads
Download

newer

older

Change in ...coreboot[master]:...

HAOUAS Elyes (Code Review)

5 May 2019 5 May '19

4:36 p.m.

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32609

Change subject: mb/lenovo/x60: Use system_reset() ......................................................................

mb/lenovo/x60: Use system_reset()

Change-Id: I4515d8d14629741f3bf49e9459d7d57c18d321ce Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/lenovo/x60/romstage.c 1 file changed, 2 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/32609/1

diff --git a/src/mainboard/lenovo/x60/romstage.c b/src/mainboard/lenovo/x60/romstage.c index 95192f7..a1f9598 100644 --- a/src/mainboard/lenovo/x60/romstage.c +++ b/src/mainboard/lenovo/x60/romstage.c @@ -19,6 +19,7 @@

#include <stdint.h> #include <arch/io.h> +#include <cf9_reset.h> #include <device/pnp_ops.h> #include <device/pci_ops.h> #include <device/pci_def.h> @@ -198,8 +199,7 @@ if (MCHBAR16(SSKPD) == 0xCAFE) { printk(BIOS_DEBUG, "Soft reset detected, rebooting properly.\n"); - outb(0x6, 0xcf9); - halt(); + system_reset(); }

/* Perform some early chipset initialization required

Attachments:

attachment.htm (text/html — 2.8 KB)

Show replies by date

Alexander Couzens (Code Review)

5 May 5 May

5:05 p.m.

Alexander Couzens has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32609 )

Change subject: mb/lenovo/x60: Use system_reset() ......................................................................

Patch Set 1: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/32609 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4515d8d14629741f3bf49e9459d7d57c18d321ce Gerrit-Change-Number: 32609 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Sun, 05 May 2019 15:05:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

5:32 p.m.

Hello Alexander Couzens, Patrick Rudolph, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32609

to look at the new patch set (#2).

Change subject: mb/lenovo/x60: Use system_reset() ......................................................................

mb/lenovo/x60: Use system_reset()

Change-Id: I4515d8d14629741f3bf49e9459d7d57c18d321ce Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/lenovo/x60/romstage.c 1 file changed, 2 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/32609/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/32609 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4515d8d14629741f3bf49e9459d7d57c18d321ce Gerrit-Change-Number: 32609 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Alexander Couzens (Code Review)

6:07 p.m.

Alexander Couzens has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32609 )

Change subject: mb/lenovo/x60: Use system_reset() ......................................................................

Patch Set 2: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/32609 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4515d8d14629741f3bf49e9459d7d57c18d321ce Gerrit-Change-Number: 32609 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Sun, 05 May 2019 16:07:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Nico Huber (Code Review)

8:46 p.m.

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32609 )

Change subject: mb/lenovo/x60: Use system_reset() ......................................................................

Patch Set 2: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/32609 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4515d8d14629741f3bf49e9459d7d57c18d321ce Gerrit-Change-Number: 32609 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Sun, 05 May 2019 18:46:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

7 May 7 May

5:52 p.m.

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32609 )

Change subject: mb/lenovo/x60: Use system_reset() ......................................................................

mb/lenovo/x60: Use system_reset()

Change-Id: I4515d8d14629741f3bf49e9459d7d57c18d321ce Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/32609 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Alexander Couzens lynxis@fe80.eu Reviewed-by: Nico Huber nico.h@gmx.de --- M src/mainboard/lenovo/x60/romstage.c 1 file changed, 2 insertions(+), 3 deletions(-)

Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved Alexander Couzens: Looks good to me, approved

diff --git a/src/mainboard/lenovo/x60/romstage.c b/src/mainboard/lenovo/x60/romstage.c index 95192f7..ea93707 100644 --- a/src/mainboard/lenovo/x60/romstage.c +++ b/src/mainboard/lenovo/x60/romstage.c @@ -19,6 +19,7 @@

#include <stdint.h> #include <arch/io.h> +#include <cf9_reset.h> #include <device/pnp_ops.h> #include <device/pci_ops.h> #include <device/pci_def.h> @@ -28,7 +29,6 @@ #include <console/console.h> #include <cpu/x86/bist.h> #include <cpu/intel/romstage.h> -#include <halt.h> #include <northbridge/intel/i945/i945.h> #include <northbridge/intel/i945/raminit.h> #include <southbridge/intel/i82801gx/i82801gx.h> @@ -198,8 +198,7 @@ if (MCHBAR16(SSKPD) == 0xCAFE) { printk(BIOS_DEBUG, "Soft reset detected, rebooting properly.\n"); - outb(0x6, 0xcf9); - halt(); + system_reset(); }

/* Perform some early chipset initialization required

-- To view, visit https://review.coreboot.org/c/coreboot/+/32609 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4515d8d14629741f3bf49e9459d7d57c18d321ce Gerrit-Change-Number: 32609 Gerrit-PatchSet: 3 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: merged

2027

days inactive

2029

days old

coreboot-gerrit@coreboot.org

5 comments

4 participants

tags (0)

participants (4)

Alexander Couzens (Code Review)
HAOUAS Elyes (Code Review)
Nico Huber (Code Review)
Patrick Georgi (Code Review)