Change in coreboot[master]: src/drivers/generic/nau8315: Add nau8315 support - coreboot-gerrit

1 Apr 2021


      Attention is currently required from: Mac Chiang, leeweitse_seven, Martin Roth, Furquan Shaikh, Tim Wawrzynczak, John Hsu, David Lin.
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51971 )
Change subject: src/drivers/generic/nau8315: Add nau8315 support
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
File src/drivers/generic/nau8315/nau8315.c:
https://review.coreboot.org/c/coreboot/+/51971/comment/66c6065c_9031e8cc 
PS3, Line 58: 	return NAU8315_ACPI_NAME;
we can return string here, remove the define.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/51971
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie883d65ced3cd95fe318ba0914ed806ff592258d
Gerrit-Change-Number: 51971
Gerrit-PatchSet: 3
Gerrit-Owner: leeweitse_seven scott.6986@hotmail.com
Gerrit-Reviewer: David Lin CTLIN0@nuvoton.com
Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: John Hsu KCHSU0@nuvoton.com
Gerrit-Reviewer: Mac Chiang mac.chiang@intel.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Mac Chiang mac.chiang@intel.com
Gerrit-Attention: leeweitse_seven scott.6986@hotmail.com
Gerrit-Attention: Martin Roth martinroth@google.com
Gerrit-Attention: Furquan Shaikh furquan@google.com
Gerrit-Attention: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Attention: John Hsu KCHSU0@nuvoton.com
Gerrit-Attention: David Lin CTLIN0@nuvoton.com
Gerrit-Comment-Date: Thu, 01 Apr 2021 04:16:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment