Attention is currently required from: Ana Carolina Cabral.
Felix Held has posted comments on this change by Ana Carolina Cabral. ( https://review.coreboot.org/c/coreboot/+/84776?usp=email )
Change subject: drivers/amd/nova: Add Nova Card common driver ......................................................................
Patch Set 10:
(1 comment)
File src/drivers/amd/nova/chip.h:
https://review.coreboot.org/c/coreboot/+/84776/comment/14f21ab6_951d7f5a?usp... : PS7, Line 10: #define NOVA_CARD_EEPROM_I2C_BUS 2 : #define NOVA_CARD_EEPROM_I2C_ADDRESS 0x55
I put it there as a "default" value, but each board can use a different setup when calling the funct […]
i'd move those to the mainboard-specific code, since at least the bus number doesn't depend on the nova card design at all. not sure if the address pins of the eeprom on the nova card are hardwired on the card or at least one address bit can be configured via the level of one pin on the nova card socket on the board
-
Felix Held (Code Review)