Attention is currently required from: Felix Singer, Wonkyu Kim, Michał Żygowski, Ravishankar Sarawadi, Stefan Reinauer, Michael Niewöhner.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56171 )
Change subject: util/inteltool: Add support for Tiger Lake chips detection and GPIOs
......................................................................
Patch Set 4:
(2 comments)
File util/inteltool/gpio_names/tigerlake.h:
PS4:
I don't think this would be copyrightable/licensable anyway
I think the other headers were split off some C file in the past. I'd just put the same license header on these, just to have one. Then again, I'm not a lawyer 😄
https://review.coreboot.org/c/coreboot/+/56171/comment/e2c79b62_c8577387
PS4, Line 300: /*
: * GPP_A group does not start right after GPP_T group and GPP_T group does not
: * start right after GPP_B. Fill the holes with Reserved on both sides.
: */
Yep. I'd stumbled upon that, too. […]
Interesting
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56171
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6071a999be9e8a372997db0369218f297e579d08
Gerrit-Change-Number: 56171
Gerrit-PatchSet: 4
Gerrit-Owner: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: Wonkyu Kim
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Wonkyu Kim
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Comment-Date: Sat, 01 Jan 2022 21:49:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Michael Niewöhner
foss@mniewoehner.de
Gerrit-MessageType: comment