Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47757 )
Change subject: soc/intel/block/pmclib.c: Properly guard apm_control() ......................................................................
soc/intel/block/pmclib.c: Properly guard apm_control()
This function is only properly implemented with SMM support.
Change-Id: I9e0fc7433a9226825f5ae4903c0ff2e0162d86ac Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/soc/intel/common/block/pmc/pmclib.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/47757/1
diff --git a/src/soc/intel/common/block/pmc/pmclib.c b/src/soc/intel/common/block/pmc/pmclib.c index 02ca6de..09af749 100644 --- a/src/soc/intel/common/block/pmc/pmclib.c +++ b/src/soc/intel/common/block/pmc/pmclib.c @@ -713,7 +713,7 @@
void pmc_set_acpi_mode(void) { - if (!acpi_is_wakeup_s3()) { + if (!CONFIG(NO_SMM) && !acpi_is_wakeup_s3()) { apm_control(APM_CNT_ACPI_DISABLE); } }
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47757 )
Change subject: soc/intel/block/pmclib.c: Properly guard apm_control() ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47757/1/src/soc/intel/common/block/... File src/soc/intel/common/block/pmc/pmclib.c:
https://review.coreboot.org/c/coreboot/+/47757/1/src/soc/intel/common/block/... PS1, Line 716: if (!CONFIG(NO_SMM) && !acpi_is_wakeup_s3()) { braces {} are not necessary for single statement blocks
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47757 )
Change subject: soc/intel/block/pmclib.c: Properly guard apm_control() ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/47757/1/src/soc/intel/common/block/... File src/soc/intel/common/block/pmc/pmclib.c:
https://review.coreboot.org/c/coreboot/+/47757/1/src/soc/intel/common/block/... PS1, Line 716: if (!CONFIG(NO_SMM) && !acpi_is_wakeup_s3()) {
braces {} are not necessary for single statement blocks
Jenkins is right
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/47757 )
Change subject: soc/intel/block/pmclib.c: Properly guard apm_control() ......................................................................
soc/intel/block/pmclib.c: Properly guard apm_control()
This function is only properly implemented with SMM support.
Change-Id: I9e0fc7433a9226825f5ae4903c0ff2e0162d86ac Signed-off-by: Arthur Heymans arthur@aheymans.xyz Reviewed-on: https://review.coreboot.org/c/coreboot/+/47757 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/soc/intel/common/block/pmc/pmclib.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/soc/intel/common/block/pmc/pmclib.c b/src/soc/intel/common/block/pmc/pmclib.c index 02ca6de..09af749 100644 --- a/src/soc/intel/common/block/pmc/pmclib.c +++ b/src/soc/intel/common/block/pmc/pmclib.c @@ -713,7 +713,7 @@
void pmc_set_acpi_mode(void) { - if (!acpi_is_wakeup_s3()) { + if (!CONFIG(NO_SMM) && !acpi_is_wakeup_s3()) { apm_control(APM_CNT_ACPI_DISABLE); } }
-
Angel Pons (Code Review) -
Arthur Heymans (Code Review)
-
build bot (Jenkins) (Code Review)
-
Patrick Georgi (Code Review)