Change in coreboot[master]: util/mb/google/hatch: Update kconfig.py to not select SOC_INTEL_COMET...
Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35563 )
Change subject: util/mb/google/hatch: Update kconfig.py to not select SOC_INTEL_COMETLAKE ......................................................................
util/mb/google/hatch: Update kconfig.py to not select SOC_INTEL_COMETLAKE
Now that SOC_INTEL_COMETLAKE is selected by default in Kconfig, utility to create a new variant does not need to do that anymore in Kconfig.name
Change-Id: If68bcf14e2e0812d4f4dcb99371c65790154ff62 Signed-off-by: Furquan Shaikh furquan@google.com --- M util/mainboard/google/hatch/kconfig.py 1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/35563/1
diff --git a/util/mainboard/google/hatch/kconfig.py b/util/mainboard/google/hatch/kconfig.py index 8b54b75..ecc24ee 100755 --- a/util/mainboard/google/hatch/kconfig.py +++ b/util/mainboard/google/hatch/kconfig.py @@ -149,7 +149,6 @@ print('\tbool "-> ' + capitalized + '"', file=outfile) print('\tselect BOARD_GOOGLE_BASEBOARD_HATCH', file=outfile) print('\tselect BOARD_ROMSIZE_KB_16384', file=outfile) - print('\tselect SOC_INTEL_COMETLAKE', file=outfile)
if __name__ == '__main__':
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35563 )
Change subject: util/mb/google/hatch: Update kconfig.py to not select SOC_INTEL_COMETLAKE ......................................................................
Patch Set 1:
Same thing, how about BOARD_GOOGLE_BASEBOARD_HATCH ?
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35563 )
Change subject: util/mb/google/hatch: Update kconfig.py to not select SOC_INTEL_COMETLAKE ......................................................................
Patch Set 1: Code-Review+2
Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35563 )
Change subject: util/mb/google/hatch: Update kconfig.py to not select SOC_INTEL_COMETLAKE ......................................................................
Patch Set 1: Code-Review+2
Andrew McRae has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35563 )
Change subject: util/mb/google/hatch: Update kconfig.py to not select SOC_INTEL_COMETLAKE ......................................................................
Patch Set 1: Code-Review+1
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35563 )
Change subject: util/mb/google/hatch: Update kconfig.py to not select SOC_INTEL_COMETLAKE ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/35563 )
Change subject: util/mb/google/hatch: Update kconfig.py to not select SOC_INTEL_COMETLAKE ......................................................................
util/mb/google/hatch: Update kconfig.py to not select SOC_INTEL_COMETLAKE
Now that SOC_INTEL_COMETLAKE is selected by default in Kconfig, utility to create a new variant does not need to do that anymore in Kconfig.name
Change-Id: If68bcf14e2e0812d4f4dcb99371c65790154ff62 Signed-off-by: Furquan Shaikh furquan@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/35563 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org Reviewed-by: Paul Fagerburg pfagerburg@chromium.org Reviewed-by: Andrew McRae amcrae@chromium.org Reviewed-by: Edward O'Callaghan quasisec@chromium.org --- M util/mainboard/google/hatch/kconfig.py 1 file changed, 0 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Tim Wawrzynczak: Looks good to me, approved Edward O'Callaghan: Looks good to me, approved Paul Fagerburg: Looks good to me, approved Andrew McRae: Looks good to me, but someone else must approve
diff --git a/util/mainboard/google/hatch/kconfig.py b/util/mainboard/google/hatch/kconfig.py index 8b54b75..ecc24ee 100755 --- a/util/mainboard/google/hatch/kconfig.py +++ b/util/mainboard/google/hatch/kconfig.py @@ -149,7 +149,6 @@ print('\tbool "-> ' + capitalized + '"', file=outfile) print('\tselect BOARD_GOOGLE_BASEBOARD_HATCH', file=outfile) print('\tselect BOARD_ROMSIZE_KB_16384', file=outfile) - print('\tselect SOC_INTEL_COMETLAKE', file=outfile)
if __name__ == '__main__':
-
Andrew McRae (Code Review) -
Edward O'Callaghan (Code Review)
-
Furquan Shaikh (Code Review)
-
Patrick Georgi (Code Review)
-
Paul Fagerburg (Code Review)
-
Tim Wawrzynczak (Code Review)