Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42020 )
Change subject: drivers/ipmi: drop redundant option `wait_for_bmc`
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42020/2/src/drivers/ipmi/ipmi_kcs_o...
File src/drivers/ipmi/ipmi_kcs_ops.c:
https://review.coreboot.org/c/coreboot/+/42020/2/src/drivers/ipmi/ipmi_kcs_o...
PS2, Line 87: Get IPMI version for ACPI and SMBIOS
that comment is a lie \o/ we don't get *anything* here
This block is actually checking if the BMC is alive, or that is what it looks like...
https://review.coreboot.org/c/coreboot/+/42020/2/src/drivers/ipmi/ipmi_kcs_o...
PS2, Line 107: retry_count < conf->bmc_boot_timeout
Comparing u8 < u16 is a potential endless loop.
Yes, should we change retry_count or bmc_boot_timeout's type?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42020
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id26f85e82a13f53a3731ab88035f2ae4bbffac00
Gerrit-Change-Number: 42020
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Niewöhner
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Jonathan Kollasch
jakllsch@kollasch.net
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jonathan Zhang
jonzhang@fb.com
Gerrit-Comment-Date: Fri, 05 Jun 2020 12:28:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Michael Niewöhner
Gerrit-MessageType: comment