Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36706 )
Change subject: sb/lynxpoint: Use macros instead of hard-coded IDs
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36706/3/src/include/device/pci_ids....
File src/include/device/pci_ids.h:
https://review.coreboot.org/c/coreboot/+/36706/3/src/include/device/pci_ids....
PS3, Line 2700: #define PCI_DEVICE_ID_INTEL_LPT_LP_LPC_VALUE 0x9c47
Searching for LPC?!?
I just think it gives a better overview about the content in the file.
It's inconsistent with the line right below btw.
I know, but this patch is not meant for renaming the other stuff. I will do that in a follow up patch.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36706
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib7d0f7122e461b78526692b78f79edcafafd3286
Gerrit-Change-Number: 36706
Gerrit-PatchSet: 3
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 20 Nov 2019 23:25:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
felixsinger@posteo.net
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment