Attention is currently required from: Bao Zheng, Robert Zieba, Raul Rangel, Marshall Dawson, Karthik Ramasubramanian.
Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62795 )
Change subject: util: Add amdfwread utility
......................................................................
Patch Set 5:
(2 comments)
File util/amdfwread/amdfwread.c:
https://review.coreboot.org/c/coreboot/+/62795/comment/d6af86b5_ebc2bc7e
PS5, Line 13: typedef enum _amd_fw_type {
Why not include amdfwtool.h for the common enums and structs?
File util/amdfwread/description.md:
https://review.coreboot.org/c/coreboot/+/62795/comment/84dbffd2_3090b1e3
PS5, Line 1: Read information from AMD Firmware combination `C`
I know amdfwtool lacks any documentation, but we shouldn't continue this pattern here. It'd be good to include a more detailed description and a usage guide (maybe usage belongs in readme.md).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62795
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I15fa07c9cad8e4640e9c40e5539b0dab44424850
Gerrit-Change-Number: 62795
Gerrit-PatchSet: 5
Gerrit-Owner: Robert Zieba
robertzieba@google.com
Gerrit-Reviewer: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Eric Peers
epeers@google.com
Gerrit-Attention: Bao Zheng
fishbaozi@gmail.com
Gerrit-Attention: Robert Zieba
robertzieba@google.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Tue, 15 Mar 2022 18:49:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment