Attention is currently required from: Bhanu Prakash Maiya, Rob Barnes, Karthik Ramasubramanian. Kenneth Chan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60442 )
Change subject: mb/google/guybrush/var/dewatt: Update for RT1019 amp dev id was changed ......................................................................
Patch Set 4:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/60442/comment/4386864a_737007b6 PS4, Line 11: 1019 id changed to 10EC1019:0/10EC1019:1 from 10EC1019:1/10EC1019:2.
New id is 10EC1019:1/10EC1019:2 right? So 10EC1019:1/10EC1019:2 from 10EC1019:0/10EC1019:1?
Original code is referring to guybrush , using I2C 0x28, 0x29, 0x2a for 1019. 0x28 (1019:0) can't be mapped (dewatt using 0x29, 0x2a), so the 1019 works will with id 1019:1 and 1019:2 before this changed. Now we can remove 0x28 and mapping id to 1019:0 and 1019:1 for audio works well. (It's failed before, w/o 0x28)
File src/mainboard/google/guybrush/variants/dewatt/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/60442/comment/97a7d805_59f12333 PS4, Line 151: register "uid" = "1"
"probed" = "1"?
I refer to guybrush CRB codes, 0x29 w/o probed=1 and 0x2a with probed=1