Change in coreboot[master]: mb/intel/dg43gt: Don't redefine VGA_BIOS_ID and MMCONF_BASE_ADDRESS

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

HAOUAS Elyes (Code Review)

4 Jul 2020 4 Jul '20

4:13 a.m.

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43134 )

Change subject: mb/intel/dg43gt: Don't redefine VGA_BIOS_ID and MMCONF_BASE_ADDRESS ......................................................................

mb/intel/dg43gt: Don't redefine VGA_BIOS_ID and MMCONF_BASE_ADDRESS

Both are already defined at northbridge/intel/x4x/Kconfig.

Change-Id: I57eb0f66d60d7120262c0993ac84e83b98ce991e Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/intel/dg43gt/Kconfig 1 file changed, 0 insertions(+), 9 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/43134/1

diff --git a/src/mainboard/intel/dg43gt/Kconfig b/src/mainboard/intel/dg43gt/Kconfig index 8bf4585..8fcbb48 100644 --- a/src/mainboard/intel/dg43gt/Kconfig +++ b/src/mainboard/intel/dg43gt/Kconfig @@ -21,15 +21,6 @@ select MAINBOARD_HAS_LIBGFXINIT select MAINBOARD_USES_IFD_GBE_REGION

-config VGA_BIOS_ID - string - default "8086,2e22" - - -config MMCONF_BASE_ADDRESS - hex - default 0xe0000000 - config MAINBOARD_DIR string default "intel/dg43gt"

Attachments:

attachment.htm (text/html — 2.8 KB)

Show replies by date

HAOUAS Elyes (Code Review)

4 Jul 4 Jul

4:30 a.m.

New subject: Change in coreboot[master]: mb/intel/dg43gt: Don't redefine VGA_BIOS_ID

HAOUAS Elyes has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/43134 )

Change subject: mb/intel/dg43gt: Don't redefine VGA_BIOS_ID ......................................................................

mb/intel/dg43gt: Don't redefine VGA_BIOS_ID

VGA_BIOS_ID is already defined at northbridge/intel/x4x/Kconfig.

Change-Id: I57eb0f66d60d7120262c0993ac84e83b98ce991e Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/intel/dg43gt/Kconfig 1 file changed, 0 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/43134/2

Nico Huber (Code Review)

4:34 a.m.

New subject: Change in coreboot[master]: mb/intel/dg43gt: Don't redefine VGA_BIOS_ID

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43134 )

Change subject: mb/intel/dg43gt: Don't redefine VGA_BIOS_ID ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43134/2/src/mainboard/intel/dg43gt/... File src/mainboard/intel/dg43gt/Kconfig:

https://review.coreboot.org/c/coreboot/+/43134/2/src/mainboard/intel/dg43gt/... PS2, Line 26: 2e22 That's not the same value as in x4x/Kconfig. Did you test this? The chip is soldered to the mainboard, right? I guess there is only one correct value.

-- To view, visit https://review.coreboot.org/c/coreboot/+/43134 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I57eb0f66d60d7120262c0993ac84e83b98ce991e Gerrit-Change-Number: 43134 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-CC: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Sat, 04 Jul 2020 11:34:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

4:40 a.m.

New subject: Change in coreboot[master]: mb/intel/dg43gt: Don't redefine VGA_BIOS_ID

HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/43134 )

Change subject: mb/intel/dg43gt: Don't redefine VGA_BIOS_ID ......................................................................

Abandoned

I did a mistake on VGA_BIOS_ID value.

HAOUAS Elyes (Code Review)

4:41 a.m.

New subject: Change in coreboot[master]: mb/intel/dg43gt: Don't redefine VGA_BIOS_ID

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43134 )

Change subject: mb/intel/dg43gt: Don't redefine VGA_BIOS_ID ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43134/2/src/mainboard/intel/dg43gt/... File src/mainboard/intel/dg43gt/Kconfig:

https://review.coreboot.org/c/coreboot/+/43134/2/src/mainboard/intel/dg43gt/... PS2, Line 26: 2e22

...

That's not the same value as in x4x/Kconfig. Did you test this? The chip […]

Oops my bad.

Thank you.

-- To view, visit https://review.coreboot.org/c/coreboot/+/43134 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I57eb0f66d60d7120262c0993ac84e83b98ce991e Gerrit-Change-Number: 43134 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-CC: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Sat, 04 Jul 2020 11:41:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber nico.h@gmx.de Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

4:48 a.m.

New subject: Change in coreboot[master]: mb/intel/dg43gt: Don't redefine VGA_BIOS_ID

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43134 )

Change subject: mb/intel/dg43gt: Don't redefine VGA_BIOS_ID ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43134/2/src/mainboard/intel/dg43gt/... File src/mainboard/intel/dg43gt/Kconfig:

https://review.coreboot.org/c/coreboot/+/43134/2/src/mainboard/intel/dg43gt/... PS2, Line 26: 2e22

...

Oops […]

8086:2e22 looks correct. see https://forum.ubuntu-fr.org/viewtopic.php?id=439844 : "nico@nico-bureau:~$ lspci -v -nn | grep VGA 00:02.0 VGA compatible controller [0300]: Intel Corporation 4 Series Chipset Integrated Graphics Controller [8086:2e22] (rev 03) "

-- To view, visit https://review.coreboot.org/c/coreboot/+/43134 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I57eb0f66d60d7120262c0993ac84e83b98ce991e Gerrit-Change-Number: 43134 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-CC: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Sat, 04 Jul 2020 11:48:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber nico.h@gmx.de Comment-In-Reply-To: HAOUAS Elyes ehaouas@noos.fr Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

4:52 a.m.

New subject: Change in coreboot[master]: mb/intel/dg43gt: Don't redefine VGA_BIOS_ID

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43134 )

Change subject: mb/intel/dg43gt: Don't redefine VGA_BIOS_ID ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43134/2/src/mainboard/intel/dg43gt/... File src/mainboard/intel/dg43gt/Kconfig:

https://review.coreboot.org/c/coreboot/+/43134/2/src/mainboard/intel/dg43gt/... PS2, Line 26: 2e22

...

8086:2e22 looks correct. […]

and here : https://bugs.launchpad.net/ubuntu/+source/xserver-xorg-video-intel/+bug/7026...

-- To view, visit https://review.coreboot.org/c/coreboot/+/43134 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I57eb0f66d60d7120262c0993ac84e83b98ce991e Gerrit-Change-Number: 43134 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-CC: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Sat, 04 Jul 2020 11:52:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber nico.h@gmx.de Comment-In-Reply-To: HAOUAS Elyes ehaouas@noos.fr Gerrit-MessageType: comment

1596

days inactive

1596

days old

coreboot-gerrit@coreboot.org

6 comments

2 participants

tags (0)

participants (2)

HAOUAS Elyes (Code Review)
Nico Huber (Code Review)