Change in coreboot[master]: soc/intel/common/block/lpss: Correct the PCI device reference

[Aamir Bohra (Code Review)]

Aamir Bohra has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34579 )

Change subject: soc/intel/common/block/lpss: Correct the PCI device reference
......................................................................

soc/intel/common/block/lpss: Correct the PCI device reference

The initial implementation was assigning the devfn as PCI device
reference directly which was incorrect.

Change-Id: Iad57e9bc6b2acf1823ee38116aea8a93feece6f9
Signed-off-by: Aamir Bohra 
---
M src/soc/intel/common/block/lpss/lpss.c
1 file changed, 2 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/34579/1

diff --git a/src/soc/intel/common/block/lpss/lpss.c b/src/soc/intel/common/block/lpss/lpss.c
index 226b4d3..d57f5f0 100644
--- a/src/soc/intel/common/block/lpss/lpss.c
+++ b/src/soc/intel/common/block/lpss/lpss.c
@@ -80,7 +80,8 @@
 void lpss_set_power_state(const struct device *dev, enum lpss_pwr_state state)
 {
 #if defined(__SIMPLE_DEVICE__)
-	pci_devfn_t lpss_dev = dev->path.pci.devfn;
+	unsigned int devfn = dev->path.pci.devfn;
+	pci_devfn_t lpss_dev = PCI_DEV(0, PCI_SLOT(devfn), PCI_FUNC(devfn));
 #else
    const struct device *lpss_dev = dev;
 #endif

[Aamir Bohra (Code Review)]

Hello Patrick Rudolph, Karthik Ramasubramanian, Subrata Banik, build bot (Jenkins), Furquan Shaikh,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/34579

to look at the new patch set (#2).

Change subject: soc/intel/common/block/lpss: Correct the PCI device reference
......................................................................

soc/intel/common/block/lpss: Correct the PCI device reference

The initial implementation was assigning the devfn as PCI device
reference directly which was incorrect.

Change-Id: Iad57e9bc6b2acf1823ee38116aea8a93feece6f9
Signed-off-by: Aamir Bohra 
---
M src/soc/intel/common/block/lpss/lpss.c
1 file changed, 3 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/34579/2

[Paul Fagerburg (Code Review)]

Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34579 )

Change subject: soc/intel/common/block/lpss: Correct the PCI device reference
......................................................................

Patch Set 2: Code-Review+1

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34579 )

Change subject: soc/intel/common/block/lpss: Correct the PCI device reference
......................................................................

Patch Set 2: Code-Review+2

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/34579 )

Change subject: soc/intel/common/block/lpss: Correct the PCI device reference
......................................................................

soc/intel/common/block/lpss: Correct the PCI device reference

The initial implementation was assigning the devfn as PCI device
reference directly which was incorrect.

Change-Id: Iad57e9bc6b2acf1823ee38116aea8a93feece6f9
Signed-off-by: Aamir Bohra 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/34579
Tested-by: build bot (Jenkins) 
Reviewed-by: Paul Fagerburg 
Reviewed-by: Tim Wawrzynczak 
---
M src/soc/intel/common/block/lpss/lpss.c
1 file changed, 3 insertions(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Tim Wawrzynczak: Looks good to me, approved
  Paul Fagerburg: Looks good to me, but someone else must approve

diff --git a/src/soc/intel/common/block/lpss/lpss.c b/src/soc/intel/common/block/lpss/lpss.c
index 226b4d3..a519bf6 100644
--- a/src/soc/intel/common/block/lpss/lpss.c
+++ b/src/soc/intel/common/block/lpss/lpss.c
@@ -14,6 +14,7 @@
  */

#include <device/mmio.h>
+#include <device/pci_def.h>
 #include <device/pci_ops.h>
 #include <intelblocks/lpss.h>

@@ -80,7 +81,8 @@
 void lpss_set_power_state(const struct device *dev, enum lpss_pwr_state state)
 {
 #if defined(__SIMPLE_DEVICE__)
-	pci_devfn_t lpss_dev = dev->path.pci.devfn;
+	unsigned int devfn = dev->path.pci.devfn;
+	pci_devfn_t lpss_dev = PCI_DEV(0, PCI_SLOT(devfn), PCI_FUNC(devfn));
 #else
    const struct device *lpss_dev = dev;
 #endif