HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34231 )
Change subject: src: Use '#include <timestamp.h>' when needed ......................................................................
src: Use '#include <timestamp.h>' when needed
Change-Id: Ic0483982e8115ae99367d08d8ed77b8a316f5405 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/drivers/amd/agesa/eventlog.c M src/drivers/intel/fsp1_1/car.c M src/include/bootblock_common.h M src/lib/bootblock.c M src/lib/decompressor.c M src/soc/intel/apollolake/bootblock/bootblock.c M src/soc/intel/denverton_ns/bootblock/bootblock.c M src/soc/qualcomm/qcs405/clock.c M src/soc/qualcomm/qcs405/gpio.c M src/soc/qualcomm/qcs405/soc.c 10 files changed, 2 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/34231/1
diff --git a/src/drivers/amd/agesa/eventlog.c b/src/drivers/amd/agesa/eventlog.c index 887da30..a5c0393 100644 --- a/src/drivers/amd/agesa/eventlog.c +++ b/src/drivers/amd/agesa/eventlog.c @@ -16,7 +16,6 @@ #include <console/console.h> #include <stdint.h> #include <string.h> -#include <timestamp.h>
#include <northbridge/amd/agesa/state_machine.h> #include <northbridge/amd/agesa/BiosCallOuts.h> diff --git a/src/drivers/intel/fsp1_1/car.c b/src/drivers/intel/fsp1_1/car.c index 1e89a8e..19eb041 100644 --- a/src/drivers/intel/fsp1_1/car.c +++ b/src/drivers/intel/fsp1_1/car.c @@ -23,7 +23,6 @@ #include <fsp/util.h> #include <fsp/memmap.h> #include <program_loading.h> -#include <timestamp.h>
/* platform_enter_postcar() determines the stack to use after * cache-as-ram is torn down as well as the MTRR settings to use, diff --git a/src/include/bootblock_common.h b/src/include/bootblock_common.h index 08b2b7a..7610047 100644 --- a/src/include/bootblock_common.h +++ b/src/include/bootblock_common.h @@ -18,7 +18,6 @@
#include <arch/cpu.h> #include <main_decl.h> -#include <timestamp.h> #include <types.h>
/* diff --git a/src/lib/bootblock.c b/src/lib/bootblock.c index c28a67a..3925e90a 100644 --- a/src/lib/bootblock.c +++ b/src/lib/bootblock.c @@ -21,6 +21,7 @@ #include <pc80/mc146818rtc.h> #include <program_loading.h> #include <symbols.h> +#include <timestamp.h>
DECLARE_OPTIONAL_REGION(timestamp);
diff --git a/src/lib/decompressor.c b/src/lib/decompressor.c index 0529d113..eb7f16c 100644 --- a/src/lib/decompressor.c +++ b/src/lib/decompressor.c @@ -19,6 +19,7 @@ #include <delay.h> #include <program_loading.h> #include <symbols.h> +#include <timestamp.h>
extern u8 compressed_bootblock[]; asm ( diff --git a/src/soc/intel/apollolake/bootblock/bootblock.c b/src/soc/intel/apollolake/bootblock/bootblock.c index ac6903a..7b4eaef 100644 --- a/src/soc/intel/apollolake/bootblock/bootblock.c +++ b/src/soc/intel/apollolake/bootblock/bootblock.c @@ -35,7 +35,6 @@ #include <soc/pci_devs.h> #include <soc/pm.h> #include <spi-generic.h> -#include <timestamp.h>
static const struct pad_config tpm_spi_configs[] = { #if CONFIG(SOC_INTEL_GLK) diff --git a/src/soc/intel/denverton_ns/bootblock/bootblock.c b/src/soc/intel/denverton_ns/bootblock/bootblock.c index 57e3a2e..e9800c8 100644 --- a/src/soc/intel/denverton_ns/bootblock/bootblock.c +++ b/src/soc/intel/denverton_ns/bootblock/bootblock.c @@ -22,7 +22,6 @@ #include <soc/bootblock.h> #include <soc/iomap.h> #include <spi-generic.h> -#include <timestamp.h> #include <console/console.h>
const FSPT_UPD temp_ram_init_params = { diff --git a/src/soc/qualcomm/qcs405/clock.c b/src/soc/qualcomm/qcs405/clock.c index 8a17e37..2d305db 100644 --- a/src/soc/qualcomm/qcs405/clock.c +++ b/src/soc/qualcomm/qcs405/clock.c @@ -14,7 +14,6 @@
#include <console/console.h> #include <device/mmio.h> -#include <timestamp.h> #include <commonlib/helpers.h> #include <string.h> #include <soc/clock.h> diff --git a/src/soc/qualcomm/qcs405/gpio.c b/src/soc/qualcomm/qcs405/gpio.c index 1d18250..93e5f76 100644 --- a/src/soc/qualcomm/qcs405/gpio.c +++ b/src/soc/qualcomm/qcs405/gpio.c @@ -15,7 +15,6 @@
#include <device/mmio.h> #include <types.h> -#include <timestamp.h> #include <gpio.h>
void gpio_configure(gpio_t gpio, uint32_t func, uint32_t pull, diff --git a/src/soc/qualcomm/qcs405/soc.c b/src/soc/qualcomm/qcs405/soc.c index b3bfb99..6735308 100644 --- a/src/soc/qualcomm/qcs405/soc.c +++ b/src/soc/qualcomm/qcs405/soc.c @@ -15,7 +15,6 @@
#include <symbols.h> #include <device/device.h> -#include <timestamp.h> #include <soc/mmu.h> #include <soc/symbols.h>
Hello Patrick Rudolph, Vanny E, Huang Jin, Lee Leahy, build bot (Jenkins), David Guckian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34231
to look at the new patch set (#2).
Change subject: src: Use '#include <timestamp.h>' when needed ......................................................................
src: Use '#include <timestamp.h>' when needed
Change-Id: Ic0483982e8115ae99367d08d8ed77b8a316f5405 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/drivers/amd/agesa/eventlog.c M src/drivers/intel/fsp1_1/car.c M src/lib/bootblock.c M src/lib/decompressor.c M src/soc/intel/apollolake/bootblock/bootblock.c M src/soc/intel/denverton_ns/bootblock/bootblock.c M src/soc/qualcomm/qcs405/clock.c M src/soc/qualcomm/qcs405/gpio.c M src/soc/qualcomm/qcs405/soc.c 9 files changed, 2 insertions(+), 7 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/34231/2
Hello Patrick Rudolph, Vanny E, Huang Jin, Lee Leahy, build bot (Jenkins), David Guckian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34231
to look at the new patch set (#3).
Change subject: src: Use '#include <timestamp.h>' when needed ......................................................................
src: Use '#include <timestamp.h>' when needed
Change-Id: Ic0483982e8115ae99367d08d8ed77b8a316f5405 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/drivers/intel/fsp1_1/car.c M src/lib/bootblock.c M src/lib/decompressor.c M src/soc/intel/apollolake/bootblock/bootblock.c M src/soc/intel/denverton_ns/bootblock/bootblock.c M src/soc/qualcomm/qcs405/clock.c M src/soc/qualcomm/qcs405/gpio.c M src/soc/qualcomm/qcs405/soc.c 8 files changed, 2 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/34231/3
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34231 )
Change subject: src: Use '#include <timestamp.h>' when needed ......................................................................
Patch Set 3: Code-Review+2
Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/34231 )
Change subject: src: Use '#include <timestamp.h>' when needed ......................................................................
src: Use '#include <timestamp.h>' when needed
Change-Id: Ic0483982e8115ae99367d08d8ed77b8a316f5405 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/34231 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Julius Werner jwerner@chromium.org --- M src/drivers/intel/fsp1_1/car.c M src/lib/bootblock.c M src/lib/decompressor.c M src/soc/intel/apollolake/bootblock/bootblock.c M src/soc/intel/denverton_ns/bootblock/bootblock.c M src/soc/qualcomm/qcs405/clock.c M src/soc/qualcomm/qcs405/gpio.c M src/soc/qualcomm/qcs405/soc.c 8 files changed, 2 insertions(+), 6 deletions(-)
Approvals: build bot (Jenkins): Verified Julius Werner: Looks good to me, approved
diff --git a/src/drivers/intel/fsp1_1/car.c b/src/drivers/intel/fsp1_1/car.c index 1e89a8e..19eb041 100644 --- a/src/drivers/intel/fsp1_1/car.c +++ b/src/drivers/intel/fsp1_1/car.c @@ -23,7 +23,6 @@ #include <fsp/util.h> #include <fsp/memmap.h> #include <program_loading.h> -#include <timestamp.h>
/* platform_enter_postcar() determines the stack to use after * cache-as-ram is torn down as well as the MTRR settings to use, diff --git a/src/lib/bootblock.c b/src/lib/bootblock.c index c28a67a..3925e90a 100644 --- a/src/lib/bootblock.c +++ b/src/lib/bootblock.c @@ -21,6 +21,7 @@ #include <pc80/mc146818rtc.h> #include <program_loading.h> #include <symbols.h> +#include <timestamp.h>
DECLARE_OPTIONAL_REGION(timestamp);
diff --git a/src/lib/decompressor.c b/src/lib/decompressor.c index 0529d113..eb7f16c 100644 --- a/src/lib/decompressor.c +++ b/src/lib/decompressor.c @@ -19,6 +19,7 @@ #include <delay.h> #include <program_loading.h> #include <symbols.h> +#include <timestamp.h>
extern u8 compressed_bootblock[]; asm ( diff --git a/src/soc/intel/apollolake/bootblock/bootblock.c b/src/soc/intel/apollolake/bootblock/bootblock.c index ac6903a..7b4eaef 100644 --- a/src/soc/intel/apollolake/bootblock/bootblock.c +++ b/src/soc/intel/apollolake/bootblock/bootblock.c @@ -35,7 +35,6 @@ #include <soc/pci_devs.h> #include <soc/pm.h> #include <spi-generic.h> -#include <timestamp.h>
static const struct pad_config tpm_spi_configs[] = { #if CONFIG(SOC_INTEL_GLK) diff --git a/src/soc/intel/denverton_ns/bootblock/bootblock.c b/src/soc/intel/denverton_ns/bootblock/bootblock.c index 57e3a2e..e9800c8 100644 --- a/src/soc/intel/denverton_ns/bootblock/bootblock.c +++ b/src/soc/intel/denverton_ns/bootblock/bootblock.c @@ -22,7 +22,6 @@ #include <soc/bootblock.h> #include <soc/iomap.h> #include <spi-generic.h> -#include <timestamp.h> #include <console/console.h>
const FSPT_UPD temp_ram_init_params = { diff --git a/src/soc/qualcomm/qcs405/clock.c b/src/soc/qualcomm/qcs405/clock.c index 56824a4..de42147 100644 --- a/src/soc/qualcomm/qcs405/clock.c +++ b/src/soc/qualcomm/qcs405/clock.c @@ -16,7 +16,6 @@ #include <device/mmio.h> #include <types.h> #include <delay.h> -#include <timestamp.h> #include <commonlib/helpers.h> #include <string.h> #include <soc/clock.h> diff --git a/src/soc/qualcomm/qcs405/gpio.c b/src/soc/qualcomm/qcs405/gpio.c index 7b2238d..fc58fae 100644 --- a/src/soc/qualcomm/qcs405/gpio.c +++ b/src/soc/qualcomm/qcs405/gpio.c @@ -16,7 +16,6 @@ #include <device/mmio.h> #include <types.h> #include <delay.h> -#include <timestamp.h> #include <gpio.h>
void gpio_configure(gpio_t gpio, uint32_t func, uint32_t pull, diff --git a/src/soc/qualcomm/qcs405/soc.c b/src/soc/qualcomm/qcs405/soc.c index b3bfb99..6735308 100644 --- a/src/soc/qualcomm/qcs405/soc.c +++ b/src/soc/qualcomm/qcs405/soc.c @@ -15,7 +15,6 @@
#include <symbols.h> #include <device/device.h> -#include <timestamp.h> #include <soc/mmu.h> #include <soc/symbols.h>
-
HAOUAS Elyes (Code Review) -
Julius Werner (Code Review)
-
Martin Roth (Code Review)