Attention is currently required from: Felix Held, Fred Reitberger, Jason Glenesk, Matt DeVillier, Patrick Rudolph.
Paul Menzel has posted comments on this change by Patrick Rudolph. ( https://review.coreboot.org/c/coreboot/+/86584?usp=email )
Change subject: soc/amd/common/block/lpc: Use ROM3 window if possible
......................................................................
Patch Set 1:
(3 comments)
Patchset:
PS1:
The linter found several things. Most(?) of them valid.
Commit Message:
https://review.coreboot.org/c/coreboot/+/86584/comment/419d9e9b_410c75f6?usp... :
PS1, Line 21:
Maybe paste the new log messages.
File src/soc/amd/common/block/lpc/mmap_boot_rom3.c:
https://review.coreboot.org/c/coreboot/+/86584/comment/0e15d61d_844faedc?usp... :
PS1, Line 27: (type == ROM2_DECODE_WINDOW) ? 2: 3);
`spaces required around that ':' (ctx:VxW)`
Please fix.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86584?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I8976273cfb31765d7f893b3fc137f117c63b6553
Gerrit-Change-Number: 86584
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 25 Feb 2025 15:09:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No