Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37762 )
Change subject: Documentation/Intel: s5 charging applet design document ......................................................................
Patch Set 4: Code-Review-1
(3 comments)
Discussion should happen on the mailing list. Please announce it there.
https://review.coreboot.org/c/coreboot/+/37762/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37762/4//COMMIT_MSG@7 PS4, Line 7: Documentation/Intel: s5 charging applet design document Please make it a statement by adding a verb (in imperative mood).
https://review.coreboot.org/c/coreboot/+/37762/4//COMMIT_MSG@13 PS4, Line 13: battery percentage when device is in s5 and being charged. How should the FSP display something (or FSP)? It’s the payloads job.
https://review.coreboot.org/c/coreboot/+/37762/4//COMMIT_MSG@16 PS4, Line 16: idea is to bring this feature to chromebooks Please add a period/dot at the end of sentences.