Attention is currently required from: Furquan Shaikh, Shreesh Chhabbi.
Shreesh Chhabbi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49766 )
Change subject: soc/intel/tgl: Disable S0i3.2 & S0i3.3 substates
......................................................................
Patch Set 4:
(1 comment)
This change is ready for review.
File src/soc/intel/tigerlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/49766/comment/bd0ef2b3_988a4bbe
PS3, Line 236: LpmStateEnableMask
I think we can probably do this: […]
Hi Furquan, I did not find the upds for external bypass, external clk gate and external phy gate. Are you suggesting to have these read from device tree and check their status to enable/disable substates?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49766
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5f2ac8b72d0c9b05bc02c092188d0c742cc83af9
Gerrit-Change-Number: 49766
Gerrit-PatchSet: 4
Gerrit-Owner: Shreesh Chhabbi
shreesh.chhabbi@intel.com
Gerrit-Reviewer: Alex Levin
levinale@google.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Raj Astekar
raj.astekar@intel.com
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Shreesh Chhabbi
shreesh.chhabbi@intel.corp-partner.google.com
Gerrit-Reviewer: Sukumar Ghorai
sukumar.ghorai@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Shreesh Chhabbi
shreesh.chhabbi@intel.com
Gerrit-Comment-Date: Tue, 02 Feb 2021 00:21:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment