Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74017 )
Change subject: soc/amd/common/block/cpu/tsc/Makefile: order targets by stage
......................................................................
Patch Set 6:
(1 comment)
File src/soc/amd/common/block/cpu/tsc/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/74017/comment/673e8225_daed5e51
PS4, Line 26: smm-$(CONFIG_SOC_AMD_COMMON_BLOCK_TSC) += tsc_freq.c
ack
CB:74150 introduces the all_x86 target which CB:74151 and following then use to finally replace this duplication. that ended up being much simpler than i expected
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74017
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id9e551b37707081eb2ea1d682013f57c7ca8aabd
Gerrit-Change-Number: 74017
Gerrit-PatchSet: 6
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 01 Apr 2023 00:03:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment