Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/28075 )
Change subject: mb/google/poppy/variants/nocturne: sx9310 to 400kb ......................................................................
mb/google/poppy/variants/nocturne: sx9310 to 400kb
The spec of the sx9310 says the I2C interface can handle standard (100kb/s) and fast mode (400kb/s). The current setting is using fast plus (1000kb/s) so this change is reducing the speed to fast mode.
I've been using the sensors with this change for a few weeks now, though I also don't recall seeing an issue prior to this change.
Change-Id: I337fc02c52565d6ec4d7bac1b3564f65238962dc Signed-off-by: Matt Delco delco@chromium.org Reviewed-on: https://review.coreboot.org/28075 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Furquan Shaikh furquan@google.com --- M src/mainboard/google/poppy/variants/nocturne/devicetree.cb 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved
diff --git a/src/mainboard/google/poppy/variants/nocturne/devicetree.cb b/src/mainboard/google/poppy/variants/nocturne/devicetree.cb index 2c074e9..4fbd0ff 100644 --- a/src/mainboard/google/poppy/variants/nocturne/devicetree.cb +++ b/src/mainboard/google/poppy/variants/nocturne/devicetree.cb @@ -298,7 +298,7 @@ chip drivers/i2c/sx9310 register "desc" = ""Right SAR Proximity Sensor"" register "irq" = "ACPI_IRQ_LEVEL_LOW(GPP_D9_IRQ)" - register "speed" = "I2C_SPEED_FAST_PLUS" + register "speed" = "I2C_SPEED_FAST" register "uid" = "0" register "reg_prox_ctrl0" = "0x10" register "reg_prox_ctrl1" = "0x00" @@ -339,7 +339,7 @@ chip drivers/i2c/sx9310 register "desc" = ""Left SAR Proximity Sensor"" register "irq" = "ACPI_IRQ_LEVEL_LOW(GPP_D10_IRQ)" - register "speed" = "I2C_SPEED_FAST_PLUS" + register "speed" = "I2C_SPEED_FAST" register "uid" = "1" register "reg_prox_ctrl0" = "0x10" register "reg_prox_ctrl1" = "0x00"
-
Patrick Georgi (Code Review)