Hung-Te Lin has submitted this change. ( https://review.coreboot.org/c/coreboot/+/56158 )
Change subject: vc/mediatek/mt8195: add FOR_COREBOOT define ......................................................................
vc/mediatek/mt8195: add FOR_COREBOOT define
The CONFIG(CHROMEOS) in DRAM calibration code was incorrectly used to identify implementations for Chromebooks (in coreboot) so we want to introduce a new flag FOR_COREBOOT to prevent confusion.
Signed-off-by: Rex-BC Chen rex-bc.chen@mediatek.com Change-Id: Ic7a6e24f41c1fda167b5d6bb2d8a2c5c79dda8de Reviewed-on: https://review.coreboot.org/c/coreboot/+/56158 Reviewed-by: Rex-BC Chen rex-bc.chen@mediatek.corp-partner.google.com Reviewed-by: Hung-Te Lin hungte@chromium.org Reviewed-by: Yu-Ping Wu yupingso@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/vendorcode/mediatek/mt8195/Makefile.inc M src/vendorcode/mediatek/mt8195/dramc/dramc_top.c 2 files changed, 13 insertions(+), 10 deletions(-)
Approvals: build bot (Jenkins): Verified Hung-Te Lin: Looks good to me, approved Yu-Ping Wu: Looks good to me, approved Rex-BC Chen: Looks good to me, but someone else must approve
diff --git a/src/vendorcode/mediatek/mt8195/Makefile.inc b/src/vendorcode/mediatek/mt8195/Makefile.inc index 2dd5d09..0873ae3 100644 --- a/src/vendorcode/mediatek/mt8195/Makefile.inc +++ b/src/vendorcode/mediatek/mt8195/Makefile.inc @@ -3,3 +3,4 @@ CPPFLAGS_common += -Isrc/soc/mediatek/mt8195/include CPPFLAGS_common += -Isrc/soc/mediatek/common/include CPPFLAGS_common += -Isrc/vendorcode/mediatek/mt8195/dramc/include -Isrc/vendorcode/mediatek/mt8195/include +CPPFLAGS_common += -DFOR_COREBOOT diff --git a/src/vendorcode/mediatek/mt8195/dramc/dramc_top.c b/src/vendorcode/mediatek/mt8195/dramc/dramc_top.c index 1595073..570c976 100644 --- a/src/vendorcode/mediatek/mt8195/dramc/dramc_top.c +++ b/src/vendorcode/mediatek/mt8195/dramc/dramc_top.c @@ -360,7 +360,7 @@ { #ifdef MTK_PMIC_MT6359 return mtk_regulator_get_voltage(®_vcore); -#elif CONFIG(CHROMEOS) +#elif defined(FOR_COREBOOT) return mainboard_get_regulator_vol(MTK_REGULATOR_VCORE); #else return 0; @@ -371,7 +371,7 @@ { #ifdef MTK_PMIC_MT6359 mtk_regulator_set_voltage(®_vdram, vdram, MAX_VDRAM); -#elif CONFIG(CHROMEOS) +#elif defined(FOR_COREBOOT) mainboard_set_regulator_vol(MTK_REGULATOR_VDD2, vdram); #endif return 0; @@ -381,7 +381,7 @@ { #ifdef MTK_PMIC_MT6359 return mtk_regulator_get_voltage(®_vdram); -#elif CONFIG(CHROMEOS) +#elif defined(FOR_COREBOOT) return mainboard_get_regulator_vol(MTK_REGULATOR_VDD2); #else return 0; @@ -392,7 +392,7 @@ { #ifdef MTK_PMIC_MT6359 mtk_regulator_set_voltage(®_vddq, vddq, MAX_VDDQ); -#elif CONFIG(CHROMEOS) +#elif defined(FOR_COREBOOT) mainboard_set_regulator_vol(MTK_REGULATOR_VDDQ, vddq); #endif return 0; @@ -402,7 +402,7 @@ { #ifdef MTK_PMIC_MT6359 return mtk_regulator_get_voltage(®_vddq); -#elif CONFIG(CHROMEOS) +#elif defined(FOR_COREBOOT) return mainboard_get_regulator_vol(MTK_REGULATOR_VDDQ); #else return 0; @@ -413,17 +413,19 @@ { #ifdef MTK_PMIC_MT6359 return mtk_regulator_set_voltage(®_vmddr, vmddr, MAX_VMDDR); -#elif CONFIG(CHROMEOS) +#elif defined(FOR_COREBOOT) mainboard_set_regulator_vol(MTK_REGULATOR_VMDDR, vmddr); -#endif return 0; +#else + return 0; +#endif }
unsigned int dramc_get_vmddr_voltage(void) { #ifdef MTK_PMIC_MT6359 return mtk_regulator_get_voltage(®_vmddr); -#elif CONFIG(CHROMEOS) +#elif defined(FOR_COREBOOT) return mainboard_get_regulator_vol(MTK_REGULATOR_VMDDR); #else return 0; @@ -434,7 +436,7 @@ { #ifdef MTK_PMIC_MT6359 return mtk_regulator_set_voltage(®_vio18, vio18, MAX_VIO18); -#elif CONFIG(CHROMEOS) +#elif defined(FOR_COREBOOT) mainboard_set_regulator_vol(MTK_REGULATOR_VDD1, vio18); return 0; #else @@ -447,7 +449,7 @@ { #ifdef MTK_PMIC_MT6359 return mtk_regulator_get_voltage(®_vio18); -#elif CONFIG(CHROMEOS) +#elif defined(FOR_COREBOOT) return mainboard_get_regulator_vol(MTK_REGULATOR_VDD1); #else return 0;