Change in coreboot[master]: soc/intel/broadwell/chip.h: Drop unused intelblocks include

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Angel Pons (Code Review)

23 Oct 2020 23 Oct '20

4:44 p.m.

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46699 )

Change subject: soc/intel/broadwell/chip.h: Drop unused intelblocks include ......................................................................

soc/intel/broadwell/chip.h: Drop unused intelblocks include

Change-Id: I499df8c282e168f9b883c2377d6b2692a355f92a Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/soc/intel/broadwell/chip.h 1 file changed, 0 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/46699/1

diff --git a/src/soc/intel/broadwell/chip.h b/src/soc/intel/broadwell/chip.h index ae43353..45d512a 100644 --- a/src/soc/intel/broadwell/chip.h +++ b/src/soc/intel/broadwell/chip.h @@ -4,7 +4,6 @@ #define _SOC_INTEL_BROADWELL_CHIP_H_

#include <drivers/intel/gma/i915.h> -#include <intelblocks/cfg.h> #include <stdint.h>

struct soc_intel_broadwell_config {

Attachments:

attachment.htm (text/html — 2.3 KB)

Show replies by date

Angel Pons (Code Review)

24 Oct 24 Oct

11:59 a.m.

Hello build bot (Jenkins), Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46699

to look at the new patch set (#4).

Change subject: soc/intel/broadwell/chip.h: Drop unused intelblocks include ......................................................................

soc/intel/broadwell/chip.h: Drop unused intelblocks include

Change-Id: I499df8c282e168f9b883c2377d6b2692a355f92a Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/soc/intel/broadwell/chip.h 1 file changed, 0 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/46699/4

-- To view, visit https://review.coreboot.org/c/coreboot/+/46699 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I499df8c282e168f9b883c2377d6b2692a355f92a Gerrit-Change-Number: 46699 Gerrit-PatchSet: 4 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Angel Pons (Code Review)

1:13 p.m.

Hello build bot (Jenkins), Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46699

to look at the new patch set (#5).

Change subject: soc/intel/broadwell/chip.h: Drop unused intelblocks include ......................................................................

soc/intel/broadwell/chip.h: Drop unused intelblocks include

Change-Id: I499df8c282e168f9b883c2377d6b2692a355f92a Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/soc/intel/broadwell/chip.h 1 file changed, 0 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/46699/5

-- To view, visit https://review.coreboot.org/c/coreboot/+/46699 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I499df8c282e168f9b883c2377d6b2692a355f92a Gerrit-Change-Number: 46699 Gerrit-PatchSet: 5 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Angel Pons (Code Review)

11:48 p.m.

Hello build bot (Jenkins), Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46699

to look at the new patch set (#7).

Change subject: soc/intel/broadwell/chip.h: Drop unused intelblocks include ......................................................................

soc/intel/broadwell/chip.h: Drop unused intelblocks include

Change-Id: I499df8c282e168f9b883c2377d6b2692a355f92a Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/soc/intel/broadwell/chip.h 1 file changed, 0 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/46699/7

-- To view, visit https://review.coreboot.org/c/coreboot/+/46699 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I499df8c282e168f9b883c2377d6b2692a355f92a Gerrit-Change-Number: 46699 Gerrit-PatchSet: 7 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Nico Huber (Code Review)

25 Oct 25 Oct

2:04 p.m.

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46699 )

Change subject: soc/intel/broadwell/chip.h: Drop unused intelblocks include ......................................................................

Patch Set 8:

Huh? shouldn't this be part of the revert ahead?

-- To view, visit https://review.coreboot.org/c/coreboot/+/46699 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I499df8c282e168f9b883c2377d6b2692a355f92a Gerrit-Change-Number: 46699 Gerrit-PatchSet: 8 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sun, 25 Oct 2020 13:04:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Angel Pons (Code Review)

2:08 p.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46699 )

Change subject: soc/intel/broadwell/chip.h: Drop unused intelblocks include ......................................................................

Patch Set 8:

...

Patch Set 8:

Huh? shouldn't this be part of the revert ahead?

Good point. Will squash.

-- To view, visit https://review.coreboot.org/c/coreboot/+/46699 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I499df8c282e168f9b883c2377d6b2692a355f92a Gerrit-Change-Number: 46699 Gerrit-PatchSet: 8 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sun, 25 Oct 2020 13:08:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Angel Pons (Code Review)

2:08 p.m.

Angel Pons has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/46699 )

Change subject: soc/intel/broadwell/chip.h: Drop unused intelblocks include ......................................................................

Abandoned

Squashed into CB:45011

-- To view, visit https://review.coreboot.org/c/coreboot/+/46699 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I499df8c282e168f9b883c2377d6b2692a355f92a Gerrit-Change-Number: 46699 Gerrit-PatchSet: 8 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: abandon

1549

days inactive

1551

days old

coreboot-gerrit@coreboot.org

6 comments

2 participants

tags (0)

participants (2)

Angel Pons (Code Review)
Nico Huber (Code Review)