Attention is currently required from: CoolStar, Jason Nien, Jon Murphy, Martin Roth.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75874?usp=email )
Change subject: mb/google/kahlee: Enable secure OS
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
File src/mainboard/google/kahlee/Kconfig:
https://review.coreboot.org/c/coreboot/+/75874/comment/160a8bc2_99165fd0 :
PS3, Line 150: def_bool
You could maybe do
```
def_bool n if CHROMEOS
def_boot y
```
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75874?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I213aebc41cae300ecee8c01fc5c7687f7e7f5ee3
Gerrit-Change-Number: 75874
Gerrit-PatchSet: 3
Gerrit-Owner: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: CoolStar
coolstarorganization@gmail.com
Gerrit-Reviewer: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-Attention: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Attention: Jon Murphy
jpmurphy@google.com
Gerrit-Attention: CoolStar
coolstarorganization@gmail.com
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Comment-Date: Fri, 16 Jun 2023 17:27:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment