Attention is currently required from: Ravi kumar, Shelley Chen, Julius Werner, mturney mturney. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52662 )
Change subject: sc7180: Add display support for mipi panels ......................................................................
Patch Set 4:
(15 comments)
File src/mainboard/google/trogdor/mainboard.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118688): https://review.coreboot.org/c/coreboot/+/52662/comment/781599fc_2a85aac4 PS4, Line 101: if(CONFIG(TROGDOR_HAS_MIPI_PANEL)) space required before the open parenthesis '('
File src/soc/qualcomm/sc7180/display/dsi.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118688): https://review.coreboot.org/c/coreboot/+/52662/comment/ef7ff448_3411ef0a PS4, Line 65: write32(&dsi0->trig_ctrl,DSI_DMA_STREAM1 << 8 | DSI_DMA_TRIGGER_SEL); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118688): https://review.coreboot.org/c/coreboot/+/52662/comment/7bc43577_b0138c34 PS4, Line 172: write32(&dsi0->int_ctrl,0x0); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118688): https://review.coreboot.org/c/coreboot/+/52662/comment/c18ce9e6_ecb3a965 PS4, Line 210: printk(BIOS_ERR, Invalid vsprintf pointer extension '%pk'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118688): https://review.coreboot.org/c/coreboot/+/52662/comment/cc1a6b5e_bf662135 PS4, Line 281: wmb(); memory barrier without comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118688): https://review.coreboot.org/c/coreboot/+/52662/comment/32f48afd_8ec8fd8d PS4, Line 289: wmb(); memory barrier without comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118688): https://review.coreboot.org/c/coreboot/+/52662/comment/b343f3a0_a203635b PS4, Line 292: wmb(); memory barrier without comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118688): https://review.coreboot.org/c/coreboot/+/52662/comment/75a22199_a878f056 PS4, Line 299: wmb(); memory barrier without comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118688): https://review.coreboot.org/c/coreboot/+/52662/comment/01e9b2d1_98c88a4f PS4, Line 302: wmb(); memory barrier without comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118688): https://review.coreboot.org/c/coreboot/+/52662/comment/abba0184_bb9a5711 PS4, Line 319: write32(&dsi0->int_ctrl,0x0); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118688): https://review.coreboot.org/c/coreboot/+/52662/comment/ddcf68c2_bdfb6b18 PS4, Line 322: setbits32(&dsi0->int_ctrl,DSI_CMD_MODE_DMA_DONE_AK); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118688): https://review.coreboot.org/c/coreboot/+/52662/comment/798c871a_06183c2f PS4, Line 325: setbits32(&dsi0->int_ctrl,DSI_CMD_MODE_MDP_DONE_AK); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118688): https://review.coreboot.org/c/coreboot/+/52662/comment/4710279f_71bad8b2 PS4, Line 328: setbits32(&dsi0->int_ctrl,DSI_VIDEO_MODE_DONE_AK); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118688): https://review.coreboot.org/c/coreboot/+/52662/comment/88c86c84_ce5eb6ac PS4, Line 333: setbits32(&dsi0->int_ctrl,DSI_ERROR_AK); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118688): https://review.coreboot.org/c/coreboot/+/52662/comment/04e154a0_40e8ba8d PS4, Line 343: if(!pinfo && !pinfo->init_cmd) space required before the open parenthesis '('
-
build bot (Jenkins) (Code Review)