Edward O'Callaghan has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37907 )
Change subject: mainboard/google/hatch: Move da7219 drv into Kohaku ......................................................................
mainboard/google/hatch: Move da7219 drv into Kohaku
There is no need to declare this in the baseboard when only one board uses this specific chip.
BUG=b:146519004 BRANCH=none TEST=./util/abuild/abuild -p none -t google/hatch -x -a
Change-Id: I7d803b5cb53daea5bbd16818aaecaf8e0970c505 Signed-off-by: Edward O'Callaghan quasisec@google.com --- M src/mainboard/google/hatch/Kconfig M src/mainboard/google/hatch/Kconfig.name 2 files changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/37907/1
diff --git a/src/mainboard/google/hatch/Kconfig b/src/mainboard/google/hatch/Kconfig index 992fa6c..ef96349 100644 --- a/src/mainboard/google/hatch/Kconfig +++ b/src/mainboard/google/hatch/Kconfig @@ -3,7 +3,6 @@ def_bool n select DRIVERS_GENERIC_GPIO_KEYS select DRIVERS_GENERIC_MAX98357A if !BOARD_GOOGLE_PUFF - select DRIVERS_I2C_DA7219 select DRIVERS_I2C_GENERIC select DRIVERS_I2C_HID select DRIVERS_I2C_SX9310 diff --git a/src/mainboard/google/hatch/Kconfig.name b/src/mainboard/google/hatch/Kconfig.name index e216135..39b65a2 100644 --- a/src/mainboard/google/hatch/Kconfig.name +++ b/src/mainboard/google/hatch/Kconfig.name @@ -24,6 +24,7 @@ bool "-> Kohaku" select BOARD_GOOGLE_BASEBOARD_HATCH select BOARD_ROMSIZE_KB_16384 + select DRIVERS_I2C_DA7219
config BOARD_GOOGLE_KINDRED bool "-> Kindred"
Daniel Kurtz has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37907 )
Change subject: mainboard/google/hatch: Move da7219 drv into Kohaku ......................................................................
Patch Set 1: Code-Review+2
This one looks reasonable independent of the MAX issue.
Hello Daniel Kurtz, Shelley Chen, build bot (Jenkins), Daniel Kurtz,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/37907
to look at the new patch set (#2).
Change subject: mainboard/google/hatch: Move da7219 drv into Kohaku ......................................................................
mainboard/google/hatch: Move da7219 drv into Kohaku
There is no need to declare this in the baseboard when only one board uses this specific chip.
BUG=b:146519004 BRANCH=none TEST=./util/abuild/abuild -p none -t google/hatch -x -a
Change-Id: I7d803b5cb53daea5bbd16818aaecaf8e0970c505 Signed-off-by: Edward O'Callaghan quasisec@google.com --- M src/mainboard/google/hatch/Kconfig M src/mainboard/google/hatch/Kconfig.name 2 files changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/37907/2
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37907 )
Change subject: mainboard/google/hatch: Move da7219 drv into Kohaku ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37907/2/src/mainboard/google/hatch/... File src/mainboard/google/hatch/Kconfig:
https://review.coreboot.org/c/coreboot/+/37907/2/src/mainboard/google/hatch/... PS2, Line 6: DRIVERS_I2C_DA7219 Selecting this should be harmless. If it goes unused, it gets dropped by the linker. Are you running into any issue with this being selected?
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37907 )
Change subject: mainboard/google/hatch: Move da7219 drv into Kohaku ......................................................................
Patch Set 2:
Patch Set 2:
(1 comment)
This patch isn't critical, it is based on a comment from Dan as a suggestion to make things a bit cleaner. I don't have strong feelings on it in any particular direction.
Edward O'Callaghan has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/37907 )
Change subject: mainboard/google/hatch: Move da7219 drv into Kohaku ......................................................................
Abandoned
no longer needed
-
Daniel Kurtz (Code Review) -
Edward O'Callaghan (Code Review)
-
Furquan Shaikh (Code Review)