Attention is currently required from: Felix Held, Jérémy Compostella, Matt DeVillier.
Hello Jérémy Compostella, Matt DeVillier, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/79834?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed: Code-Review+1 by Matt DeVillier, Verified+1 by build bot (Jenkins)
Change subject: arch/x86/include/smm: improve documentation of call_smm ......................................................................
arch/x86/include/smm: improve documentation of call_smm
Since the inline assembly code doesn't make it exactly obvious how this function to call the APMC SMI handler works in detail and especially how it passes the sub-command and argument pointer to the SMI handler, add a more detailed explanation as comment.
Signed-off-by: Felix Held felix-coreboot@felixheld.de Change-Id: I3566af191492ce00a3033335ff80e01c33e98e63 --- M src/arch/x86/include/smm_call.h 1 file changed, 4 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/79834/2