Attention is currently required from: Philipp Deppenwiese, Martin Roth, Christian Walter, Julius Werner, Arthur Heymans.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51923 )
Change subject: [WIP]security/tpm: Add option to init TPM in bootblock
......................................................................
Patch Set 2:
(3 comments)
File src/security/tpm/Kconfig:
https://review.coreboot.org/c/coreboot/+/51923/comment/261c8026_860e873e
PS2, Line 113: Initialize tpm inside the bootblock instead of ramstage.
… for hardware assisted root of trust measurement.
https://review.coreboot.org/c/coreboot/+/51923/comment/2cd2233f_0b0fa6c6
PS2, Line 113: tpm
TPM
File src/security/tpm/tspi/tspi.c:
https://review.coreboot.org/c/coreboot/+/51923/comment/f18a8fe2_968f05d2
PS2, Line 112: return 1;
Use ternary operator?
return (ENV_BOOTBLOCK) ? tpm_is_setup : 1;
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51923
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifacba5d9ab19b47968b4f2ed5731ded4aac55022
Gerrit-Change-Number: 51923
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Mon, 29 Mar 2021 16:34:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment