Change in coreboot[master]: mb/google/kahlee/treeya/audio: use proper I2C base address define - coreboot-gerrit

15 Oct 2021


      Attention is currently required from: Martin Roth, Felix Held.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58335 )
Change subject: mb/google/kahlee/treeya/audio: use proper I2C base address define
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
File src/mainboard/google/kahlee/variants/treeya/audio.c:
https://review.coreboot.org/c/coreboot/+/58335/comment/d438db8a_ad983124 
PS1, Line 20: 	do {
lol, ugh this code is hard to follow. wonder if it could be replaced with a DEV_PTR()
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/58335
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie8d6a438f76cd33929f5070f9ec6b2f280f471a0
Gerrit-Change-Number: 58335
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Martin Roth martinroth@google.com
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 15 Oct 2021 14:36:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment