Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29669 )
Change subject: cpu/intel/sandybridge: Add `hyper_threading` option ......................................................................
Patch Set 2:
Can we make this a common intel cpu change with an interface for multiple cpu implementations.
You mean if this code works for other platforms?
I vagely recal a discussion on irc where it was said that all Intel platforms starting from sandybridge have the same interface? A common implementation would be nice, which probably easier and cleaner with a C_ENVIRONMENT_BOOTBLOCK implementation.
I've checked the documentation, it's the same for Haswell and Broadwell too. For newer platforms, it has to be handled by or coordinated with the blob, I guess.
If anyone wants to take this over, I wouldn't mind. I don't have time for this atm and consider it low priority (should actually be handled by the OS, IMHO).