Jacob Garber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34486 )
Change subject: soc/intel/broadwell: Change variable back to u32 ......................................................................
soc/intel/broadwell: Change variable back to u32
commit bde6d309df (x86: Change MMIO addr in readN(addr)/writeN(addr, val) to pointer) accidentally changed the type of reg32 to a u8 *, so change it back to a u32.
Change-Id: If6beff17ed3ddf85889aba5f41d1ba112cd74075 Signed-off-by: Jacob Garber jgarber1@ualberta.ca Found-by: Coverity CID 1402160 --- M src/soc/intel/broadwell/minihd.c 1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/34486/1
diff --git a/src/soc/intel/broadwell/minihd.c b/src/soc/intel/broadwell/minihd.c index d44e153..d51230a 100644 --- a/src/soc/intel/broadwell/minihd.c +++ b/src/soc/intel/broadwell/minihd.c @@ -64,7 +64,8 @@ static void minihd_init(struct device *dev) { struct resource *res; - u8 *base, reg32; + u8 *base; + u32 reg32; int codec_mask, i;
/* Find base address */
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34486 )
Change subject: soc/intel/broadwell: Change variable back to u32 ......................................................................
Patch Set 1: Code-Review+2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34486 )
Change subject: soc/intel/broadwell: Change variable back to u32 ......................................................................
Patch Set 1: Code-Review+2
Of course, it had to happen in a giant patch...
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34486 )
Change subject: soc/intel/broadwell: Change variable back to u32 ......................................................................
Patch Set 1: Code-Review+2
Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/34486 )
Change subject: soc/intel/broadwell: Change variable back to u32 ......................................................................
soc/intel/broadwell: Change variable back to u32
commit bde6d309df (x86: Change MMIO addr in readN(addr)/writeN(addr, val) to pointer) accidentally changed the type of reg32 to a u8 *, so change it back to a u32.
Change-Id: If6beff17ed3ddf85889aba5f41d1ba112cd74075 Signed-off-by: Jacob Garber jgarber1@ualberta.ca Found-by: Coverity CID 1402160 Reviewed-on: https://review.coreboot.org/c/coreboot/+/34486 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: HAOUAS Elyes ehaouas@noos.fr Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Martin Roth martinroth@google.com --- M src/soc/intel/broadwell/minihd.c 1 file changed, 2 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Martin Roth: Looks good to me, approved HAOUAS Elyes: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/src/soc/intel/broadwell/minihd.c b/src/soc/intel/broadwell/minihd.c index d44e153..d51230a 100644 --- a/src/soc/intel/broadwell/minihd.c +++ b/src/soc/intel/broadwell/minihd.c @@ -64,7 +64,8 @@ static void minihd_init(struct device *dev) { struct resource *res; - u8 *base, reg32; + u8 *base; + u32 reg32; int codec_mask, i;
/* Find base address */
-
Angel Pons (Code Review) -
HAOUAS Elyes (Code Review)
-
Jacob Garber (Code Review)
-
Martin Roth (Code Review)