Change in coreboot[master]: src/mediatek/mt8192: use Mediatek mt8192 vendor code(CB:50294)
Attention is currently required from: Hung-Te Lin, Martin Roth. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51125 )
Change subject: src/mediatek/mt8192: use Mediatek mt8192 vendor code(CB:50294) ......................................................................
Patch Set 2:
(22 comments)
File src/soc/mediatek/common/dram_init.c:
https://review.coreboot.org/c/coreboot/+/51125/comment/76aaccaa_b1ad2ad5 PS2, Line 33: print("dram_init: start\n"); Prefer using '"%s...", __func__' to using 'dram_init', this function's name, in a string
https://review.coreboot.org/c/coreboot/+/51125/comment/9a45d393_8fc2fb63 PS2, Line 49: print("dram_init: dram init end (result: %d)\n", hdr->status); Prefer using '"%s...", __func__' to using 'dram_init', this function's name, in a string
File src/soc/mediatek/mt8192/include/soc/dramc_mt8192.h:
https://review.coreboot.org/c/coreboot/+/51125/comment/600e717f_c2931bdc PS2, Line 7: { open brace '{' following enum go on the same line
https://review.coreboot.org/c/coreboot/+/51125/comment/0545d59e_9a209f4f PS2, Line 8: CHANNEL_A = 0, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/51125/comment/b67b9bb1_170d6d35 PS2, Line 9: CHANNEL_B, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/51125/comment/c418fae6_cca5bc93 PS2, Line 10: CHANNEL_MAX please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/51125/comment/4613f171_3c0026b6 PS2, Line 14: { open brace '{' following enum go on the same line
https://review.coreboot.org/c/coreboot/+/51125/comment/6d5545aa_e01ccf71 PS2, Line 15: RANK_0 = 0, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/51125/comment/423d6623_3c64d738 PS2, Line 16: RANK_1, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/51125/comment/4d247003_c4e7197a PS2, Line 17: RANK_MAX please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/51125/comment/f3895853_3a6e94db PS2, Line 21: { open brace '{' following enum go on the same line
https://review.coreboot.org/c/coreboot/+/51125/comment/34fc3467_b332459b PS2, Line 22: DRAM_DFS_SHUFFLE_1 = 0, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/51125/comment/f2454f57_485aee5a PS2, Line 23: DRAM_DFS_SHUFFLE_2, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/51125/comment/11595161_874bad53 PS2, Line 24: DRAM_DFS_SHUFFLE_3, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/51125/comment/72a17e92_6962871a PS2, Line 25: DRAM_DFS_SHUFFLE_4, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/51125/comment/36824b57_cffdc027 PS2, Line 26: DRAM_DFS_SHUFFLE_5, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/51125/comment/ab80dc79_c21aa909 PS2, Line 27: DRAM_DFS_SHUFFLE_6, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/51125/comment/e51539b3_169ed2c3 PS2, Line 28: DRAM_DFS_SHUFFLE_7, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/51125/comment/852e261d_6dbbf8e8 PS2, Line 29: DRAM_DFS_SHUFFLE_MAX please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/51125/comment/1e19749e_4072bda3 PS2, Line 40: { open brace '{' following enum go on the same line
https://review.coreboot.org/c/coreboot/+/51125/comment/9f22fe39_41027812 PS2, Line 41: CBT_NORMAL_MODE = 0, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/51125/comment/24ad5804_bd8ba534 PS2, Line 42: CBT_BYTE_MODE1 please, no spaces at the start of a line
-
build bot (Jenkins) (Code Review)