Attention is currently required from: Felix Held, Fred Reitberger, Jason Glenesk, Martin Roth, Matt DeVillier, Tim Van Patten.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78231?usp=email )
Change subject: soc/amd/common/vboot: Fix the PSP verstage timestamps
......................................................................
Patch Set 1:
(1 comment)
File src/soc/amd/common/vboot/vboot_bootblock.c:
https://review.coreboot.org/c/coreboot/+/78231/comment/a9cf5944_087a4d7b :
PS1, Line 48: * We ignore the time between x86 processor release and bootblock.
: * Since timestamp_add subtracts base_time, we first add old base_time
: * to make it absolute then add base_timestamp again since
: * it'll be a new base_time.
It looks like this needs to be updated to describe why `tse->entry_stamp` is added also.
Actually this comment already is saying that base_time is added to entry_timestamp to make it absolute.
Conversion comment is coming after that. So I think the comment itself does not need update.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78231?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3e52bef22f65596152f29c511bed680427660ff5
Gerrit-Change-Number: 78231
Gerrit-PatchSet: 1
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Tim Van Patten
timvp@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Tim Van Patten
timvp@google.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Wed, 04 Oct 2023 17:11:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Van Patten
timvp@google.com
Gerrit-MessageType: comment