Attention is currently required from: Jason Glenesk, Raul Rangel, Furquan Shaikh, Mathew King, Felix Held.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52041 )
Change subject: soc/amd/cezanne: Add modern standby option to chip config
......................................................................
Patch Set 6:
(1 comment)
File src/soc/amd/cezanne/Kconfig:
https://review.coreboot.org/c/coreboot/+/52041/comment/58125796_3b2c4a99
PS3, Line 216: AMD_ENABLE_MODERN_STANDBY
I don't feel like I understand the benefit of separate S3/S0ix builds over a runtime setting. […]
I would prefer a single build supporting both S3 and S0i3, instead of maintaining separate builds for that. Run-time config is going to help switch between S3 and S0i3 easily.
Based on the way Kconfig is being used to enable S0i3, I dont see any code-space savings too.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52041
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0d09bd4361f5f47360daf750efbc993010804902
Gerrit-Change-Number: 52041
Gerrit-PatchSet: 6
Gerrit-Owner: Jason Glenesk
jason.glenesk@amd.corp-partner.google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Mathew King
mathewk@chromium.org
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Karthikeyan Ramasubramanian
kramasub@chromium.org
Gerrit-CC: Martin Roth
martinroth@google.com
Gerrit-CC: Matt Papageorge
matthewpapa07@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Mathew King
mathewk@chromium.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@amd.corp-partner.google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Thu, 15 Apr 2021 19:34:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Mathew King
mathewk@chromium.org
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment