Attention is currently required from: Anil Kumar K, Paul Menzel, Rizwan Qureshi, Subrata Banik, sridhar siricilla.
Krishna P Bhat D has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75760?usp=email )
Change subject: soc/intel/cse: Add entries to eventlog on PSR backup events
......................................................................
Patch Set 14:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/75760/comment/c7d86476_28d58f8b :
PS11, Line 21: Event(B9)
The elogtool patch got merged here: https://review.coreboot. […]
Done
File src/soc/intel/common/block/cse/cse_lite.c:
https://review.coreboot.org/c/coreboot/+/75760/comment/89f90463_f896e689 :
PS13, Line 1117: else
: elog_add_event_byte(ELOG_TYPE_PSR_DATA_BACKUP,
: ELOG_PSR_DATA_BACKUP_SUCCESS);
need to use braces to maintain the semantics of `if` block above
Acknowledged
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75760?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I2459a2b941d28a87b6c78f75dbe8779d73328d7a
Gerrit-Change-Number: 75760
Gerrit-PatchSet: 14
Gerrit-Owner: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Reviewer: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: sridhar siricilla
siricillasridhar@gmail.com
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: sridhar siricilla
siricillasridhar@gmail.com
Gerrit-Comment-Date: Tue, 26 Sep 2023 17:29:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Rizwan Qureshi
rizwan.qureshi@intel.com
Comment-In-Reply-To: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-MessageType: comment