Change in ...coreboot[master]: TEMP: NOT FOR REVIEW: Mistral: Add board id detection using TPM

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Patrick Georgi (Code Review)

10 Apr 2019 10 Apr '19

8:48 p.m.

Hello nsekar@codeaurora.org,

I'd like you to do a code review. Please visit

https://review.coreboot.org/c/coreboot/+/32271

to review the following change.

Change subject: TEMP: NOT FOR REVIEW: Mistral: Add board id detection using TPM ......................................................................

TEMP: NOT FOR REVIEW: Mistral: Add board id detection using TPM

This patch adds support to select the board id based on the TPM availability.

Change-Id: Ib75d51a21a6129e3650e2af24ff85f37a462591b Signed-off-by: Nitheesh Sekar nsekar@codeaurora.org --- M src/mainboard/google/mistral/boardid.c 1 file changed, 16 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/32271/1

diff --git a/src/mainboard/google/mistral/boardid.c b/src/mainboard/google/mistral/boardid.c index 8258ac3..9a0d309 100644 --- a/src/mainboard/google/mistral/boardid.c +++ b/src/mainboard/google/mistral/boardid.c @@ -32,7 +32,22 @@ [1] = GPIO(106), [0] = GPIO(105)};

- bid = gpio_binary_first_base3_value(pins, ARRAY_SIZE(pins)); + if (is_tpm_detected() == 0) { + bid = 25; /* Assign 25 for EVB boards */ + printk(BIOS_DEBUG, "EVB Board ID: %d\n", bid); + } else { + bid = 0; /* Assign 0 for Proto boards */ + + /* The board id assigned for Proto boards is 0. + * Since gpios are not wired in the initial phase, + * we will get 0 whihch is a coincidence. + * To make sure it starts working, after gpios are + * wired, reassign the value read from gpios to id. + */ + bid = gpio_binary_first_base3_value(pins, ARRAY_SIZE(pins)); + + printk(BIOS_DEBUG, "Proto Board ID: %d\n", bid); + }

return bid; }

Attachments:

attachment.htm (text/html — 3.8 KB)

Show replies by date

Patrick Georgi (Code Review)

10 Apr 10 Apr

9 p.m.

Hello build bot (Jenkins), nsekar@codeaurora.org,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32271

to look at the new patch set (#3).

Change subject: TEMP: NOT FOR REVIEW: Mistral: Add board id detection using TPM ......................................................................

TEMP: NOT FOR REVIEW: Mistral: Add board id detection using TPM

This patch adds support to select the board id based on the TPM availability.

Change-Id: Ib75d51a21a6129e3650e2af24ff85f37a462591b Signed-off-by: Nitheesh Sekar nsekar@codeaurora.org --- M src/mainboard/google/mistral/boardid.c 1 file changed, 17 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/32271/3

Patrick Georgi (Code Review)

25 Apr 25 Apr

7:04 p.m.

Hello build bot (Jenkins), Nitheesh Sekar,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32271

to look at the new patch set (#8).

Change subject: TEMP: NOT FOR REVIEW: Mistral: Add board id detection using TPM ......................................................................

TEMP: NOT FOR REVIEW: Mistral: Add board id detection using TPM

This patch adds support to select the board id based on the TPM availability.

Change-Id: Ib75d51a21a6129e3650e2af24ff85f37a462591b Signed-off-by: Nitheesh Sekar nsekar@codeaurora.org --- M src/mainboard/google/mistral/boardid.c 1 file changed, 19 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/32271/8

Patrick Georgi (Code Review)

24 Jul 24 Jul

9:28 p.m.

New subject: Change in coreboot[master]: TEMP: NOT FOR REVIEW: Mistral: Add board id detection using TPM

Hello build bot (Jenkins), Nitheesh Sekar,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32271

to look at the new patch set (#10).

Change subject: TEMP: NOT FOR REVIEW: Mistral: Add board id detection using TPM ......................................................................

TEMP: NOT FOR REVIEW: Mistral: Add board id detection using TPM

This patch adds support to select the board id based on the TPM availability.

Change-Id: Ib75d51a21a6129e3650e2af24ff85f37a462591b Signed-off-by: Nitheesh Sekar nsekar@codeaurora.org --- M src/mainboard/google/mistral/boardid.c 1 file changed, 13 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/32271/10

-- To view, visit https://review.coreboot.org/c/coreboot/+/32271 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib75d51a21a6129e3650e2af24ff85f37a462591b Gerrit-Change-Number: 32271 Gerrit-PatchSet: 10 Gerrit-Owner: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Nitheesh Sekar nsekar@codeaurora.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

build bot (Jenkins) (Code Review)

9:30 p.m.

New subject: Change in coreboot[master]: TEMP: NOT FOR REVIEW: Mistral: Add board id detection using TPM

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32271 )

Change subject: TEMP: NOT FOR REVIEW: Mistral: Add board id detection using TPM ......................................................................

Patch Set 10:

(2 comments)

https://review.coreboot.org/c/coreboot/+/32271/10/src/mainboard/google/mistr... File src/mainboard/google/mistral/boardid.c:

https://review.coreboot.org/c/coreboot/+/32271/10/src/mainboard/google/mistr... PS10, Line 41: if (bid == 0) that open brace { should be on the previous line

https://review.coreboot.org/c/coreboot/+/32271/10/src/mainboard/google/mistr... PS10, Line 43: if (is_tpm_detected() == 0) { braces {} are not necessary for single statement blocks

Patrick Georgi (Code Review)

9:38 p.m.

New subject: Change in coreboot[master]: TEMP: NOT FOR REVIEW: Mistral: Add board id detection using TPM

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32271 )

Change subject: TEMP: NOT FOR REVIEW: Mistral: Add board id detection using TPM ......................................................................

Patch Set 10:

(2 comments)

https://review.coreboot.org/c/coreboot/+/32271/10/src/mainboard/google/mistr... File src/mainboard/google/mistral/boardid.c:

https://review.coreboot.org/c/coreboot/+/32271/10/src/mainboard/google/mistr... PS10, Line 41: if (bid == 0)

...

that open brace { should be on the previous line

Done

https://review.coreboot.org/c/coreboot/+/32271/10/src/mainboard/google/mistr... PS10, Line 43: if (is_tpm_detected() == 0) {

...

braces {} are not necessary for single statement blocks

yuck.

-- To view, visit https://review.coreboot.org/c/coreboot/+/32271 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib75d51a21a6129e3650e2af24ff85f37a462591b Gerrit-Change-Number: 32271 Gerrit-PatchSet: 10 Gerrit-Owner: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Nitheesh Sekar nsekar@codeaurora.org Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 24 Jul 2019 19:38:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: comment

Patrick Georgi (Code Review)

9:38 p.m.

New subject: Change in coreboot[master]: TEMP: NOT FOR REVIEW: Mistral: Add board id detection using TPM

Hello build bot (Jenkins), Nitheesh Sekar,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32271

to look at the new patch set (#11).

Change subject: TEMP: NOT FOR REVIEW: Mistral: Add board id detection using TPM ......................................................................

TEMP: NOT FOR REVIEW: Mistral: Add board id detection using TPM

This patch adds support to select the board id based on the TPM availability.

Change-Id: Ib75d51a21a6129e3650e2af24ff85f37a462591b Signed-off-by: Nitheesh Sekar nsekar@codeaurora.org --- M src/mainboard/google/mistral/boardid.c 1 file changed, 12 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/32271/11

-- To view, visit https://review.coreboot.org/c/coreboot/+/32271 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib75d51a21a6129e3650e2af24ff85f37a462591b Gerrit-Change-Number: 32271 Gerrit-PatchSet: 11 Gerrit-Owner: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Nitheesh Sekar nsekar@codeaurora.org Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

build bot (Jenkins) (Code Review)

9:38 p.m.

New subject: Change in coreboot[master]: TEMP: NOT FOR REVIEW: Mistral: Add board id detection using TPM

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32271 )

Change subject: TEMP: NOT FOR REVIEW: Mistral: Add board id detection using TPM ......................................................................

Patch Set 11:

(1 comment)

https://review.coreboot.org/c/coreboot/+/32271/11/src/mainboard/google/mistr... File src/mainboard/google/mistral/boardid.c:

https://review.coreboot.org/c/coreboot/+/32271/11/src/mainboard/google/mistr... PS11, Line 42: if (is_tpm_detected() == 0) { braces {} are not necessary for single statement blocks

-- To view, visit https://review.coreboot.org/c/coreboot/+/32271 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib75d51a21a6129e3650e2af24ff85f37a462591b Gerrit-Change-Number: 32271 Gerrit-PatchSet: 11 Gerrit-Owner: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Nitheesh Sekar nsekar@codeaurora.org Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 24 Jul 2019 19:38:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Patrick Georgi (Code Review)

9:39 p.m.

New subject: Change in coreboot[master]: TEMP: NOT FOR REVIEW: Mistral: Add board id detection using TPM

Hello build bot (Jenkins), Nitheesh Sekar,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32271

to look at the new patch set (#12).

Change subject: TEMP: NOT FOR REVIEW: Mistral: Add board id detection using TPM ......................................................................

TEMP: NOT FOR REVIEW: Mistral: Add board id detection using TPM

This patch adds support to select the board id based on the TPM availability.

Change-Id: Ib75d51a21a6129e3650e2af24ff85f37a462591b Signed-off-by: Nitheesh Sekar nsekar@codeaurora.org --- M src/mainboard/google/mistral/boardid.c 1 file changed, 12 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/32271/12

-- To view, visit https://review.coreboot.org/c/coreboot/+/32271 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib75d51a21a6129e3650e2af24ff85f37a462591b Gerrit-Change-Number: 32271 Gerrit-PatchSet: 12 Gerrit-Owner: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Nitheesh Sekar nsekar@codeaurora.org Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

build bot (Jenkins) (Code Review)

9:42 p.m.

New subject: Change in coreboot[master]: TEMP: NOT FOR REVIEW: Mistral: Add board id detection using TPM

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32271 )

Change subject: TEMP: NOT FOR REVIEW: Mistral: Add board id detection using TPM ......................................................................

Patch Set 12:

(1 comment)

https://review.coreboot.org/c/coreboot/+/32271/12/src/mainboard/google/mistr... File src/mainboard/google/mistral/boardid.c:

https://review.coreboot.org/c/coreboot/+/32271/12/src/mainboard/google/mistr... PS12, Line 42: if (is_tpm_detected() == 0) { braces {} are not necessary for single statement blocks

-- To view, visit https://review.coreboot.org/c/coreboot/+/32271 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib75d51a21a6129e3650e2af24ff85f37a462591b Gerrit-Change-Number: 32271 Gerrit-PatchSet: 12 Gerrit-Owner: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Nitheesh Sekar nsekar@codeaurora.org Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 24 Jul 2019 19:42:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Nitheesh Sekar (Code Review)

29 Jul 29 Jul

2:41 p.m.

New subject: Change in coreboot[master]: TEMP: NOT FOR REVIEW: Mistral: Add board id detection using TPM

Nitheesh Sekar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32271 )

Change subject: TEMP: NOT FOR REVIEW: Mistral: Add board id detection using TPM ......................................................................

Patch Set 12:

Hi Patrick,

We can abandon this patch since we have to clean up the EVB code. We will not be needing to select the board_id based on TPM. Just reading the board id from gpio would be sufficient.

Thanks, Nitheesh

-- To view, visit https://review.coreboot.org/c/coreboot/+/32271 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib75d51a21a6129e3650e2af24ff85f37a462591b Gerrit-Change-Number: 32271 Gerrit-PatchSet: 12 Gerrit-Owner: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Nitheesh Sekar nsekar@codeaurora.org Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 29 Jul 2019 12:41:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Patrick Georgi (Code Review)

2 Aug 2 Aug

8:28 p.m.

New subject: Change in coreboot[master]: TEMP: NOT FOR REVIEW: Mistral: Add board id detection using TPM

Patrick Georgi has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/32271 )

Change subject: TEMP: NOT FOR REVIEW: Mistral: Add board id detection using TPM ......................................................................

Abandoned

we don't do that anymore

-- To view, visit https://review.coreboot.org/c/coreboot/+/32271 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib75d51a21a6129e3650e2af24ff85f37a462591b Gerrit-Change-Number: 32271 Gerrit-PatchSet: 12 Gerrit-Owner: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Nitheesh Sekar nsekar@codeaurora.org Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: abandon

1940

days inactive

2054

days old

coreboot-gerrit@coreboot.org

11 comments

3 participants

tags (0)

participants (3)

build bot (Jenkins) (Code Review)
Nitheesh Sekar (Code Review)
Patrick Georgi (Code Review)