Change in coreboot[master]: soc/intel/basecode: Add support for updating ucode loaded via FIT
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/27369 )
Change subject: soc/intel/basecode: Add support for updating ucode loaded via FIT ......................................................................
Patch Set 57:
(5 comments)
https://review.coreboot.org/c/coreboot/+/27369/57/src/soc/intel/common/basec... File src/soc/intel/common/basecode/fw_update/ucode_update.c:
https://review.coreboot.org/c/coreboot/+/27369/57/src/soc/intel/common/basec... PS57, Line 255: BOOT_STATE_INIT_ENTRY(BS_PRE_DEVICE, BS_ON_ENTRY, ucode_fw_sync, NULL); adding a line without newline at end of file
https://review.coreboot.org/c/coreboot/+/27369/57/src/soc/intel/common/basec... File src/soc/intel/common/basecode/include/intelbasecode/ucode_update.h:
https://review.coreboot.org/c/coreboot/+/27369/57/src/soc/intel/common/basec... PS57, Line 7: * This is a weak implementation to reboot after ucode update is finished. trailing whitespace
https://review.coreboot.org/c/coreboot/+/27369/57/src/soc/intel/common/basec... PS57, Line 14: * enabled. This returns non-zero if recovery mode enabled and can be overridden by trailing whitespace
https://review.coreboot.org/c/coreboot/+/27369/57/src/soc/intel/common/basec... PS57, Line 20: * This checks if the currently running microcode matches with the one in staging area and trailing whitespace
https://review.coreboot.org/c/coreboot/+/27369/57/src/soc/intel/common/basec... PS57, Line 21: * the current slot. If they do not match update the staging area with the right version and trailing whitespace
-
build bot (Jenkins) (Code Review)