Change in coreboot[master]: soc/amd/common/block/include/gpio_defs: drop 8k pullup define - coreboot-gerrit

25 Nov 2021


      Attention is currently required from: Jason Glenesk, Raul Rangel.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59591 )
Change subject: soc/amd/common/block/include/gpio_defs: drop 8k pullup define
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/59591/comment/bd144411_bbbdbdfe 
PS1, Line 9: reserved in all SoCs
...
the Cezanne PPR has reset values for that bit and it's 0, so this patch shouldn't change the value t […]
updated the commit message with the information from this and some internal discussion
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/59591
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaf2d4eec7a13e558c75d7edea343b876909a5b33
Gerrit-Change-Number: 59591
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel rrangel@chromium.org
Gerrit-Comment-Date: Thu, 25 Nov 2021 11:06:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Marshall Dawson marshalldawson3rd@gmail.com
Comment-In-Reply-To: Felix Held felix-coreboot@felixheld.de
Gerrit-MessageType: comment