Attention is currently required from: Hung-Te Lin, Jarried Lin, Yu-Ping Wu.
Yidi Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85841?usp=email )
Change subject: soc/mediatek/mt8196: Add clk_buf drivers ......................................................................
Patch Set 1:
(7 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/85841/comment/eddfc85a_0e8b06f0?usp... : PS1, Line 9: Mt8196 use mt6685 clk_buf, and will use new RC mode with srclken_rc. Please add more details.
File src/soc/mediatek/mt8196/clkbuf_ctl.c:
https://review.coreboot.org/c/coreboot/+/85841/comment/147af90b_02749434?usp... : PS1, Line 238: remove one blank line
https://review.coreboot.org/c/coreboot/+/85841/comment/099ffcff_73b7abd6?usp... : PS1, Line 341: 0x1 align with first param
https://review.coreboot.org/c/coreboot/+/85841/comment/a49bc541_0e54e5fa?usp... : PS1, Line 413: _Static_assert(ARRAY_SIZE(ox) == XO_NUMBER, "Wrong array size of ox"); move to line 206
https://review.coreboot.org/c/coreboot/+/85841/comment/c2ea2bae_f848c396?usp... : PS1, Line 419: 124 please define
File src/soc/mediatek/mt8196/include/soc/clkbuf_ctl.h:
https://review.coreboot.org/c/coreboot/+/85841/comment/757b683a_9b9458e5?usp... : PS1, Line 378: remove the blank line
https://review.coreboot.org/c/coreboot/+/85841/comment/7626ca87_2698fb73?usp... : PS1, Line 379: /* Update PMIF base by platform if needed */ : #if !defined(PMIF_SPMI_P_BASE_CLKBUF) : #define PMIF_SPMI_P_BASE_CLKBUF 0x1C014000 : #endif /* !defined(PMIF_SPMI_P_BASE_CLKBUF) */ You should add PMIF_SPMI_P_CLKBUF_BASE to addressmap.h