John Zhao has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45531 )
Change subject: drivers/intel/mipi_camera: Avoid resource leak ......................................................................
drivers/intel/mipi_camera: Avoid resource leak
Coverity detects variable dsd going out of scope leaks the storage it points to. Move dsd resource allocation after sanity check for config->nvm_compact to avoid leak.
Found-by: Coverity CID 1432727 TEST=Built and boot up to kernel on Volteer.
Signed-off-by: John Zhao john.zhao@intel.com Change-Id: I86af322dc78845b8b312b6815135336c2c56b4dd --- M src/drivers/intel/mipi_camera/camera.c 1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/45531/1
diff --git a/src/drivers/intel/mipi_camera/camera.c b/src/drivers/intel/mipi_camera/camera.c index fed0ff6..d4cf33d 100644 --- a/src/drivers/intel/mipi_camera/camera.c +++ b/src/drivers/intel/mipi_camera/camera.c @@ -452,11 +452,13 @@ static void camera_fill_nvm(const struct device *dev) { struct drivers_intel_mipi_camera_config *config = dev->chip_info; - struct acpi_dp *dsd = acpi_dp_new_table("_DSD"); + struct acpi_dp *dsd;
if (!config->nvm_compat) return;
+ dsd = acpi_dp_new_table("_DSD"); + /* It might be possible to default size or width based on type. */ if (!config->disable_nvm_defaults && !config->nvm_pagesize) config->nvm_pagesize = 1;
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45531 )
Change subject: drivers/intel/mipi_camera: Avoid resource leak ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45531 )
Change subject: drivers/intel/mipi_camera: Avoid resource leak ......................................................................
drivers/intel/mipi_camera: Avoid resource leak
Coverity detects variable dsd going out of scope leaks the storage it points to. Move dsd resource allocation after sanity check for config->nvm_compact to avoid leak.
Found-by: Coverity CID 1432727 TEST=Built and boot up to kernel on Volteer.
Signed-off-by: John Zhao john.zhao@intel.com Change-Id: I86af322dc78845b8b312b6815135336c2c56b4dd Reviewed-on: https://review.coreboot.org/c/coreboot/+/45531 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org --- M src/drivers/intel/mipi_camera/camera.c 1 file changed, 3 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Tim Wawrzynczak: Looks good to me, approved
diff --git a/src/drivers/intel/mipi_camera/camera.c b/src/drivers/intel/mipi_camera/camera.c index fed0ff6..d4cf33d 100644 --- a/src/drivers/intel/mipi_camera/camera.c +++ b/src/drivers/intel/mipi_camera/camera.c @@ -452,11 +452,13 @@ static void camera_fill_nvm(const struct device *dev) { struct drivers_intel_mipi_camera_config *config = dev->chip_info; - struct acpi_dp *dsd = acpi_dp_new_table("_DSD"); + struct acpi_dp *dsd;
if (!config->nvm_compat) return;
+ dsd = acpi_dp_new_table("_DSD"); + /* It might be possible to default size or width based on type. */ if (!config->disable_nvm_defaults && !config->nvm_pagesize) config->nvm_pagesize = 1;
-
John Zhao (Code Review) -
Patrick Georgi (Code Review)
-
Tim Wawrzynczak (Code Review)